This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Add support for query-level DESC clustering order in the mock #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcjensen
force-pushed
the
query-clustering-order-in-mock
branch
from
3b9040a to
a5e658c
Compare
gcjensen
commented
Jan 15, 2024
| @@ -625,6 +625,13 @@ func (q *MockFilter) Read(out interface{}) Op { | |||
| return err | |||
| } | |||
|
|
|||
| // If a query-level clustering order has been provided, and the first one is descending, reverse the list | |||
| if len(m.options.ClusteringOrder) > 0 && m.options.ClusteringOrder[0].Direction == DESC { | |||
| for i, j := 0, len(result)-1; i < j; i, j = i+1, j-1 { | |||
There was a problem hiding this comment.
we could bump the version of Go so that slices.Reverse is available, but I was worried that might have some knock on effects and make this a bigger change (due to dependencies and the CI etc. etc.)
theninj4
approved these changes
Jan 16, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently adding support to
gen-daofor allowing the sort order used by the generated List function to be reversed. Whilst doing so, I noticed that the gocassa mocking doesn't currently respect the provided clustering order.We've previously added mock support for clustering order at table creation (#82), but not as part of a query.
See https://github.com/monzo/wearedev/pull/172946 for the
gen-daochange.