Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow the Behat timeout factor to be configured #295

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

NeillM
Copy link
Contributor

@NeillM NeillM commented Jul 1, 2024

Changes for #294 we have been running a version of this patch on our automatic testing server for years now.

@NeillM
Copy link
Contributor Author

NeillM commented Jul 1, 2024

I'm guessing the app test failures here are related to the reason Fall back to ionic7 app runtime was created

@NoelDeMartin
Copy link
Contributor

@NeillM The fix for the app failures has been merged, if you rebase you should get rid of the app errors.

@NeillM
Copy link
Contributor Author

NeillM commented Jul 1, 2024

Thanks, I have rebased it

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NeillM , looks spot-on!

Was going to comment about when 0 (zero) or 1 is the best default, but both lead to the same, from memory (aka, original timeout applied), so no problem, so far.

@stronk7 stronk7 merged commit e0b3993 into moodlehq:main Jul 1, 2024
127 checks passed
@stronk7 stronk7 linked an issue Jul 1, 2024 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Behat timeout be increased via an environment variable
3 participants