fix: propagate error instead of panicking in manual sealing #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
RomarQ
requested review from
gonzamontiel,
TarekkMA,
librelois,
ahmadkaouk and
Agusrodri
WASM runtime size check:Compared to target branchMoonbase runtime: 2196 KB (no changes) ✅ Moonbeam runtime: 2140 KB (no changes) ✅ Moonriver runtime: 2132 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2196 KB (+236 KB compared to latest release) Moonbeam runtime: 2140 KB (+216 KB compared to latest release) Moonriver runtime: 2132 KB (+208 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-panic-when-using-manual-sealing +/- ##
==========================================================================
- Coverage 79.22% 79.21% -0.01%
Files 299 299
+ Lines 87253 87255 +2
==========================================================================
- Hits 69118 69117 -1
+ Misses 18135 18138 +3
|
Agusrodri
approved these changes
Sep 27, 2024
librelois
approved these changes
Sep 28, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes #2917, by propagating the error instead of panicking.
By propagating the error, the frontier RPC will now return the error below instead of crashing the node:
What important points reviewers should know?
This only affects the dev mode (Manual sealing).