Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable native foreign assets on moonriver and moonbeam #3051

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ahmadkaouk
Copy link
Contributor

@ahmadkaouk ahmadkaouk commented Nov 21, 2024

What does it do?

This PR enables the creation of new foreign assets on moonriver and moonbeam using the new pallet moonbeam-foreign-assets.

⚠️ Breaking Changes ⚠️

Refer to this pull request for a comprehensive overview of the breaking changes.

Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2232 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2232 KB (+236 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

@ahmadkaouk ahmadkaouk self-assigned this Nov 21, 2024
@ahmadkaouk ahmadkaouk added A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Nov 21, 2024
@ahmadkaouk ahmadkaouk marked this pull request as ready for review November 21, 2024 13:50
Copy link
Contributor

Coverage Report

@@                          Coverage Diff                           @@
##           master   ahmad-enable-native-foreign-assets      +/-   ##
======================================================================
- Coverage   79.34%                               79.33%   -0.01%     
  Files         301                                  301              
+ Lines       87834                                87844      +10     
======================================================================
  Hits        69685                                69685              
+ Misses      18149                                18159      +10     
Files Changed Coverage
/runtime/moonbeam/src/xcm_config.rs 43.27% (-2.18%) 🔽
/runtime/moonriver/src/xcm_config.rs 43.27% (-2.18%) 🔽

Coverage generated Thu Nov 21 13:57:58 UTC 2024

Copy link
Contributor

@RomarQ RomarQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomarQ RomarQ requested a review from Agusrodri November 21, 2024 16:59
@ahmadkaouk ahmadkaouk merged commit 981f908 into master Nov 21, 2024
42 of 49 checks passed
@ahmadkaouk ahmadkaouk deleted the ahmad-enable-native-foreign-assets branch November 21, 2024 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited evm-native-foreign-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants