Fix panic when fetching block header in backend.state_at #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2232 KB (no changes) ✅ Moonriver runtime: 2232 KB (no changes) ✅ Compared to latest release (runtime-3300)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2232 KB (+236 KB compared to latest release) Moonriver runtime: 2232 KB (+240 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/fix-lazy-loading-panic +/- ##
============================================================
Coverage 74.81% 74.81% 0.00%
Files 369 369
Lines 94137 94137
============================================================
Hits 70421 70421
Misses 23716 23716
|
gonzamontiel
approved these changes
Nov 25, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Propagate error instead of panicking when calling
state_atwhen using the lazy loading backend.