Use ParachainBlockImport::new_with_delayed_best_block when experimental_block_import_strategy is disabled #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_block_import_strategy is disabled
RomarQ
added
the
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
crystalin
approved these changes
Dec 6, 2024
crystalin
added
the
D3-trivial
Coverage Report@@ Coverage Diff @@
## master rq/fix-block-import +/- ##
======================================================
Coverage 74.58% 74.58% 0.00%
Files 375 375
+ Lines 95682 95684 +2
======================================================
+ Hits 71356 71357 +1
+ Misses 24326 24327 +1
|
|
Updated the description |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fixes an issue related to a suggestion provided here: paritytech/polkadot-sdk#4333
When using
ParachainBlockImport::new, theblock import parametersdo not contain anyfork_choice, which causes the block import pipeline to fail.Fix on the nimbus side: Moonsong-Labs/moonkit#56