feat(gov): normalize FastGeneralAdmin track origin for creating new foreign assets #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
D3-trivial
TarekkMA
previously approved these changes
Jan 28, 2025
WASM runtime size check:Compared to target branchMoonbase runtime: 2420 KB (no changes) 🚨 Moonbeam runtime: 2404 KB (no changes) 🚨 Moonriver runtime: 2392 KB (-8 KB) ✅ Compared to latest release (runtime-3401)Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨 Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨 Moonriver runtime: 2392 KB (+380 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/update-pallet_xcm_weight_trader-origin +/- ##
============================================================================
Coverage 74.59% 74.59% 0.00%
Files 380 380
Lines 96029 96029
============================================================================
Hits 71632 71632
Misses 24397 24397
|
stiiifff
previously approved these changes
Jan 29, 2025
RomarQ
dismissed stale reviews from manuelmauro, stiiifff, and TarekkMA
via
cf29013
TarekkMA
previously approved these changes
Jan 30, 2025
stiiifff
reviewed
Jan 31, 2025
stiiifff
approved these changes
Jan 31, 2025
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates EVMForeignAsset and XcmTrader to require the same track origin when creating a new foreign asset.
Now,
GeneralAdmintrack can be used whenFastGeneralAdminis allowed.