Do cheap check first

moorscode · Feb 13, 2021 · 5bbb825 · 5bbb825
1 parent 6a5f85b
commit 5bbb825
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/backend/src/pokers/poker-room.ts b/backend/src/pokers/poker-room.ts
@@ -300,7 +300,7 @@ export class PokerRoom {
 	 * @returns {void}
 	 */
 	private changeVote( memberId: string, vote: VoteValue ): void {
-		if ( ! this.hasEverybodyVoted( this.currentStory ) ) {
+		if ( ! this.hasAllVotes( this.currentStory ) ) {
 			this.getCurrentVote( memberId ).initialValue = vote;
 		}
 		if ( this.getCurrentVote( memberId ).initialValue === "coffee" ) {
@@ -339,9 +339,10 @@ export class PokerRoom {
 	 * @returns {Vote[]} List of votes.
 	 */
 	public getCurrentVotes(): Vote[] {
-		if ( this.hasEverybodyVoted( this.currentStory ) || this.currentStory.votesRevealed ) {
+		if ( this.currentStory.votesRevealed || this.hasAllVotes( this.currentStory ) ) {
 			return this.getUnobscuredVotes( this.currentStory );
 		}
+
 		return this.getObscuredVotes( this.currentStory );
 	}