Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Let people clear the default value of an attribute when inheriting #176

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Let people clear the default value of an attribute when inheriting #176

wants to merge 8 commits into from

Commits on Jun 18, 2020

  1. Make this code slightly less clever, in anticipation of a future change.

    @skington
    skington committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    885bf88 View commit details
    Browse the repository at this point in the history

  2. Let people say has '+attribute_name' => ( clear_default => 1 }; 

    This doesn't set the default to undef (i.e. if you don't set the
attribute value, it's set to undef - which may violate a type
constraint). Rather, it removes entirely the default value.
    @skington
    skington committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8ec5ed3 View commit details
    Browse the repository at this point in the history

  3. Explain and document clear_default.

    @skington
    skington committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    dd1744f View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Don't let people clear attributes that don't exist.

    @skington
    skington committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    223cb17 View commit details
    Browse the repository at this point in the history

  2. Don't let people say both clear_default *and* provide a default value.

    @skington
    skington committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    8316b79 View commit details
    Browse the repository at this point in the history

  3. Obviously make sure that if you clear an already-empty attribute, 

    that works and nothing complains.
    @skington
    skington committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ea2e8e1 View commit details
    Browse the repository at this point in the history

  4. Still complain if we provide a default value *and* clear_value, but the 

    default value is false.
    @skington
    skington committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    018e5a0 View commit details
    Browse the repository at this point in the history

  5. White space shenanigans.

    @skington
    skington committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ac11c03 View commit details
    Browse the repository at this point in the history