Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add group functionality #763

Merged

Conversation

mrpmohiburrahman
Copy link
Contributor

@mrpmohiburrahman mrpmohiburrahman commented Nov 11, 2024

This PR partially addresses issue #747.

Implemented Changes

Added getGroups() function which returns an array of group objects, including identifier and name

Request for Feedback

I would appreciate feedback from the maintainers on whether I am heading in the right direction and if I should proceed with the implementation of other functions.

Planned Functions

Below are the additional functions I am considering implementing:

  • getGroup(groupId) - Returns the group matching the provided groupId.
  • contactsInGroup(groupId) - Retrieves all contacts within a specified group.
  • addGroup(groupDetails) - Adds a new group.
  • updateGroup(groupId, updatedDetails) - Updates an existing group's details.
  • deleteGroup(groupId) - Deletes a group by groupId.
  • addContactsToGroup(groupId, contactIds) - Adds contacts to a group.
  • removeContactsFromGroup(groupId, contactIds) - Removes specified contacts from a group.

Question for Maintainers

Given the number of planned functions, would you prefer that I create separate PRs for each function, or include all of them in this PR?

closes #747

@mrpmohiburrahman mrpmohiburrahman mentioned this pull request Nov 11, 2024
@morenoh149
Copy link
Owner

Thanks. Regarding your questions, lets put all those functions into one PR. Will you submit another PR or add the functions into this PR?

@mrpmohiburrahman
Copy link
Contributor Author

Thanks. Regarding your questions, lets put all those functions into one PR. Will you submit another PR or add the functions into this PR?

I will add other functions into this pr. Give me a day.

@mrpmohiburrahman
Copy link
Contributor Author

Thanks. Regarding your questions, lets put all those functions into one PR. Will you submit another PR or add the functions into this PR?

Hi, @morenoh149 ,

I have implemented all the required functions and updated the documentation in the README.md file.

Please review the changes at your convenience. Let me know if any further modifications are needed.

@morenoh149
Copy link
Owner

lgtm

@morenoh149 morenoh149 merged commit 1d5eae7 into morenoh149:master Nov 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS groups
2 participants