Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug fix: prettyForestplot bugs #167

Merged
merged 1 commit into from
Feb 28, 2023
Merged

bug fix: prettyForestplot bugs #167

merged 1 commit into from
Feb 28, 2023

Conversation

Kdreval
Copy link
Collaborator

@Kdreval Kdreval commented Feb 28, 2023

I have recently broken the prettyForestplot. This PR fixes the bugs described in #166

Copy link
Contributor

@mattssca mattssca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kostia! I will approve this PR with a minor comment that you can deal with as you like. Since dplyr is specified under import, and because the mutate function does not have any conflicting function names from any other package, it is not necessary to specify the package before calling this function (i.e mutate::dplyr). It can simply just be mutate. Thanks!

@Kdreval
Copy link
Collaborator Author

Kdreval commented Feb 28, 2023

Thanks, Kostia! I will approve this PR with a minor comment that you can deal with as you like. Since dplyr is specified under import, and because the mutate function does not have any conflicting function names from any other package, it is not necessary to specify the package before calling this function (i.e mutate::dplyr). It can simply just be mutate. Thanks!

Oh good! Thanks for the update!

@Kdreval Kdreval merged commit d8d643f into master Feb 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants