-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update to handle capture data #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good updates, see comments for suggestions and questions. For me, I got an error when testing get_ssm_by_sample
related to the maf path (saying the file does not exist). I updated my working directory but still got a similar error. For testing, I cloned this branch and ran the functions after loading this specific gamblr branch. This is how I ran the previously mentioned function ssm = get_ssm_by_sample(this_sample_id = "BLGSP-71-06-00001-01A-11D")
while cd onto the cloned gamblr branch.
base_directory="/home/rmorin/", | ||
my_name="Ryan Morin", | ||
my_gitlab_email="rdmorin@sfu.ca"){ | ||
wflow_git_config(user.name = my_name, user.email = my_gitlab_email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add overwrite option (default to FALSE?) to wflow_git_config()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand what causes this. Which "flavour" did you specify? Presumably just the default. Can you please retry with flavour="clustered"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!
After updating this line to
if(this_pairing_status == "unmatched")
andflavour = "clustered"
the function runs the intended way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I can't finalize and test the new version of this function without the final deblacklisted MAFs.
|
||
#' Set up a fresh instance of a website to host on gitlab | ||
#' | ||
#' @param site_base_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding descriptions of parameters, even though rather self-explenatory (to have consistent documentation generated).
#' @param site_base_name | ||
#' @param base_directory | ||
#' | ||
#' @return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing
I think this is good to go |
Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.Optional but preferred with PRs
Checklist for New Functions
Required
I documented my function using ROxygen style.)
All parameters for the function are described in the documentation and the function has a decriptive title.
Example:
import
statment.Example:
Checklist for changes to existing code
I added/removed arguments to a function and updated documentation for all changed/new arguments
I tested the new code for compatability with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)