Point to aave-v3-origin #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
commented
Oct 15, 2024
QGarchery
commented
Oct 15, 2024
QGarchery
commented
Oct 15, 2024
QGarchery
commented
Oct 15, 2024
QGarchery
commented
Oct 16, 2024
QGarchery
commented
Oct 17, 2024
QGarchery
commented
Oct 17, 2024
QGarchery
commented
Oct 17, 2024
MathisGD
approved these changes
Oct 25, 2024
MathisGD
approved these changes
Nov 2, 2024
Draft
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
See more information on the changes as comments on the code below.
Submodule issue, fixed in 0459b24
Logs of resolving submodules when checking out this branch:Notice that OZ submodule was previously resolved to point to the aave-v3-origin version. This is because
lib/aave-v3-origin/lib/solidity-utils/lib/openzeppelin-contracts-upgradeable/lib/openzeppelin-contractscontains the following remapping:@openzeppelin/contracts-upgradeable/=contracts/.