-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
bound (fixed) rate #128
Merged
Merged
bound (fixed) rate #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
adhusson,
Rubilmax,
QGarchery,
MerlinEgalite and
Jean-Grimal
February 28, 2024 09:48
Rubilmax
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I have missed this 🤦
QGarchery
reviewed
Feb 28, 2024
MerlinEgalite
approved these changes
Feb 28, 2024
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Rubilmax
approved these changes
Mar 1, 2024
Jean-Grimal
approved these changes
Mar 1, 2024
MathisGD
commented
Mar 1, 2024
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Rubilmax
approved these changes
Mar 1, 2024
QGarchery
approved these changes
Mar 1, 2024
MerlinEgalite
approved these changes
Mar 1, 2024
Jean-Grimal
approved these changes
Mar 4, 2024
MathisGD
changed the base branch from
feat/fixed-rate
to
docs/natspec-in-interface
March 4, 2024 10:49
MerlinEgalite
approved these changes
Mar 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cantinasec/review-morpho/issues/18
I choose the same max rate as the one of AdaptiveCurveIRM