fix: downgrade to 0.8.19 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julien <julien@morpho.xyz>
julien-devatom
requested review from
a team,
Rubilmax,
MerlinEgalite,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
Rubilmax
approved these changes
Oct 30, 2023
QGarchery
requested changes
Oct 30, 2023
There was a problem hiding this comment.
While we are at it, I would suggest changing the pragma of the interface too. Basically, there is no reason to restrict pragmas based on new features that it provides, so it should be based on bugfixes and breaking changes. See full discussion here
Signed-off-by: julien <julien@morpho.xyz>
Rubilmax
approved these changes
Oct 31, 2023
Jean-Grimal
approved these changes
Oct 31, 2023
QGarchery
approved these changes
Oct 31, 2023
MerlinEgalite
approved these changes
Oct 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cantina issue