Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: use docker-compose to start etcd and layotto #635 #657

Merged
merged 8 commits into from
Jun 20, 2022
Merged

chore: use docker-compose to start etcd and layotto #635 #657

merged 8 commits into from
Jun 20, 2022

Conversation

YoungMa962
Copy link
Contributor

@YoungMa962 YoungMa962 commented Jun 16, 2022

  • add docker compose

  • modify the etcd quickstart doc

What this PR does:
add use docker-compose to start etcd and layotto

Which issue(s) this PR fixes:

Fixes #635

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


* add docker compose

* modify the etcd quickstart doc
@mosn-community-bot
Copy link

Hi @YoungMa962, welcome to mosn community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #657 (ca148bf) into main (00a5984) will not change coverage.
The diff coverage is n/a.

❗ Current head ca148bf differs from pull request most recent head af5bd54. Consider uploading reports for the commit af5bd54 to get more accurate results

@@           Coverage Diff           @@
##             main     #657   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa9090...af5bd54. Read the comment docs.

docs/zh/start/configuration/start.md Outdated Show resolved Hide resolved
docs/zh/start/configuration/start.md Show resolved Hide resolved
@seeflood
Copy link
Member

seeflood commented Jun 17, 2022

Thanks for your contribution!
I can run the new demo successfully on my laptop:
image

YoungMa962 and others added 4 commits June 17, 2022 17:02
Co-authored-by: seeflood <zhou.qunli@foxmail.com>
* Update docs/en/start/configuration/start.md

* Update docs/zh/start/sequencer/start.md

* Update docs/en/start/sequencer/start.md
* fix some words
* add Stop containers and release resources step
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood requested review from a team June 18, 2022 06:01
@seeflood seeflood merged commit f625e97 into mosn:main Jun 20, 2022
@YoungMa962 YoungMa962 deleted the Layotto_飞船_YoungMa962 branch June 20, 2022 06:33
@seeflood seeflood linked an issue Jun 29, 2022 that may be closed by this pull request
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users run our demo without go environment use docker-compose to start etcd and layotto
3 participants