Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve GTFS-RT Support #182

Merged
merged 21 commits into from
Dec 19, 2021
Merged

Improve GTFS-RT Support #182

merged 21 commits into from
Dec 19, 2021

Conversation

felixguendling
Copy link
Member

No description provided.

@derhuerst
Copy link

I'm curious: Specifically, how does this PR improve MOTIS' GTFS-RT support?

@felixguendling
Copy link
Member Author

Thank you for your interest.

We implemented the MOTIS GTFS-RT code with focus on the Switzerland GTFS from SBB. When trying the GTFS-RT stream from Poznan (mentioned in #181), I noticed that we do not cover some parts of the GTFS-RT specification (specifically how trips and stops can be identified). So these changes should support the Poznan GTFS-RT data - and therefore all GTFS-RT feeds that work similarly.

The GTFS-RT functionality in MOTIS is rather new and may be a little bit rough around the edges. We are trying hard to improve support - at least for all features that are used in practice.

After that works, I'm also planning a major refactoring of the code handling GTFS-RT to improve compactness and maintainability.

@felixguendling
Copy link
Member Author

Seems like delays seem to be working now for this feed!! 🚀 😀

@wkulesza thank you for providing the feed URL!

Screenshot from 2021-12-18 12-14-11
Screenshot from 2021-12-18 12-13-53

However, from the GTFS-static documentation about stop_sequence in stops.txt

The values must increase along the trip but do not need to be consecutive.

For the GTFS-RT-feed to work properly, these values have to be consecutive and start with zero. This is the case for most feeds. We're planning to add support for non-zero-based and non-consecutive stop_sequence numbers nonetheless.

@felixguendling felixguendling merged commit f2ac193 into master Dec 19, 2021
@felixguendling felixguendling deleted the gtfs-rt branch December 19, 2021 12:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants