compact api: destination needs to be object #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destination is available in IntermodalRoutingRequest which prevents detection of compact API format
pablohoch
reviewed
May 15, 2023
base/module/src/fix_json.cc
Outdated
Comment on lines
55
to
57
| if (!(v.HasMember("destination") && | ||
| v.FindMember("destination")->value.IsString()) && | ||
| !v.HasMember("content")) { |
There was a problem hiding this comment.
Müsste destination nicht in beiden Fällen ein Object sein (Destination oder IntermodalDestination)?
Vielleicht sollte man prüfen, ob destination und content vorhanden sind -> dann wird es wohl nicht das kompakte Format sein (if (!(v.HasMember("destination") && v.HasMember("content")))).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destination is available in IntermodalRoutingRequest which prevents detection of compact API format