Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cmake: Add option to pass flags not used for host tools #689

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jbruechert
Copy link
Contributor

This allows to target machines that support more instructions than the build machine.

Not sure if this is a good way to achieve this, but it at least doesn't require significant changes.

@felixguendling
Copy link
Member

Compiling mimalloc with -Weverything [...] -Werror has a good chance to cause trouble because we don't want to fix random warnings in mimalloc when we update. So maybe it would be better to have a separate set of flags (MOTIS_ARCH_FLAGS?) that's independent of the aggressive -Weverything [...] -Werror flags that are only relevant for our own code.

@jbruechert
Copy link
Contributor Author

That's pretty mich what this does except for different variable naming, isn't it?

@felixguendling
Copy link
Member

Ahh. Mistook it for motis-compile-options.

@felixguendling felixguendling merged commit cc02b4c into motis-project:master Dec 24, 2024
11 of 12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants