-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extend ABI to expose journeys, footpaths, cancellations #139
Extend ABI to expose journeys, footpaths, cancellations #139
Conversation
…t propagation of lower bounded time for has_time
Regarding formatting: We switched to Clang-18 ( |
@mority can you please check the GTFS RT part with the proposed propagation bugfix? Thank you :) |
Regarding formatting: I just forgot to format this file, and the More details regarding propagation: As far as I understood this was meant to avoid vehicles travelling back in time due to missing or wrong realtime updates, e.g. having a delay of one hour at one stop and arriving on time at the next stop which is only a minute away. I think I even encountered this in the wild back in the day (with the RT feed from gtfs.de which uses absolute timestamps), but I'm not sure anymore, would have to check. |
ed2bfcc
to
3b66452
Compare
Sorry for the wait, good points. I have refactored accordingly, but instead of an enum I have used |
This finally addresses most of the open todos from #66, among other things:
There is one change I made that has an impact outside of the ABI: For absolute-time-based GTFSRTs (
ev.has_time()
), the time-travel-corrected time will be propagated in L119 just like for delay-based GTFSRTs in L94. I think this was a bug.