Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix incorrect audio tracks #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Effectimminent
Copy link

@Effectimminent Effectimminent commented Nov 15, 2024

fixes many of the projects audio issues by letting yt-dlp do more of the heavy lifting
Breaks audio and video only modes may also effect custom players

Copy link
Member

@r3tr0ananas r3tr0ananas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, vlc does work with this plugin and with this pr it will break.
Secondly, we still wanna keep the audio feature.

@THEGOLDENPRO
Copy link
Member

Yeah I don't think I like this idea. In v4.5 of mov-cli this will be fixed anyways as you'll have multiple audio tracks in the player to pick from.

Also this still can be fixed in v4.4 as the problem is for some reason the localization code in the plugin is not picking up the English audio track, that's a bug and should just generally be looked into and fixed by itself.

I've been busy recently with other projects and irl commitments so sorry that I haven't been able to look into this yet.

@Effectimminent
Copy link
Author

Effectimminent commented Nov 15, 2024

after spending a couple hours trying to fix the changes i think fixing it in mov-cli would definitely be the better option (in fact the issue i ran into while trying to fix my changes would be easliy fixed with some tiny changes over there) however i would also recommend leaning on yt-dlp's features rather than having an entire python function(that can run 100s of times depending on the video ) dedicated to finding the best streams

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants