Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cherry pick #350 #752

Merged
merged 5 commits into from
Jan 26, 2018
Merged

cherry pick #350 #752

merged 5 commits into from
Jan 26, 2018

Conversation

rhaschke
Copy link
Contributor

This is another attempt to migrate changes of #350 from Kinetic to Indigo maintaining ABI compatibility.
A recent attempt () only considered a small fraction of the original PR, still leading to errors (#749).

Now I ported most of the other stuff, including the unit test.
@rkeatin3 However, as I don't have a running Indigo system anymore, I appreciate real-world testing. Particularly, check whether fetching the current state from the rviz MotionPlanning plugin works without issues.

@rkeatin3
Copy link
Contributor

I should be able to get to this later today.

@v4hn
Copy link
Contributor

v4hn commented Jan 26, 2018

Please do so @rkeatin3 .
Otherwise this looks good to me.

@rkeatin3
Copy link
Contributor

It looks to me that this issue has been resolved; my script that plans/executes in rapid succession has run for 30 minutes or so without seeing that error (which previously came up quite often). I also tested snapping the goal state to the current state within the Rviz plugin without any problems.

@v4hn v4hn merged commit d8150fc into moveit:indigo-devel Jan 26, 2018
@v4hn
Copy link
Contributor

v4hn commented Jan 26, 2018

@rkeatin3 thank you for testing. Glad to hear your issue is resolved :)

@rhaschke rhaschke deleted the pr-cherry-pick-#350 branch March 18, 2018 10:53
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
…oveit#752) (moveit#781)

Co-authored-by: Marco Lapolla <marco.lapolla5@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants