Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: explicitly add the same namespace as the parent node #3360

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KazuyaOguma18
Copy link
Contributor

@KazuyaOguma18 KazuyaOguma18 commented Feb 22, 2025

Description

Problem

When launching the move_group node with a namespace and running moveit_py within a node that has the same namespace, the moveit_simple_controller_manager lacked a namespace. As a result, the robot could not operate because the action for trajectory execution was missing the necessary namespace.

Solution

Explicitly added the parent node's namespace.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.84%. Comparing base (83d05ae) to head (ffa3c14).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3360      +/-   ##
==========================================
- Coverage   46.25%   45.84%   -0.41%     
==========================================
  Files         717      717              
  Lines       62596    62577      -19     
  Branches     7568     7564       -4     
==========================================
- Hits        28947    28681     -266     
- Misses      33482    33729     +247     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass
Copy link
Contributor

Thank you! A small formatting fix is needed, but otherwise looks good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants