Skip to content

Support worker threads #127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2019
Merged

Support worker threads #127

merged 1 commit into from
Oct 6, 2019

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Oct 6, 2019 •
edited
Loading

Fixes #124 and sindresorhus/execa#357

This library currently does not work inside worker threads because of the use of process.chdir(). This fixes that.

This was referenced Oct 6, 2019
Closed
Closed
@codecov
Copy link

codecov bot commented Oct 6, 2019 •
edited
Loading

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #127   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         160    162    +2     
  Branches       32     34    +2     
=====================================
+ Hits          160    162    +2
Impacted Files Coverage Δ
lib/util/resolveCommand.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7cd3d...450f763. Read the comment docs.

@satazor satazor merged commit cfd49c9 into moxystudio:master Oct 6, 2019
@satazor
Copy link
Contributor

satazor commented Oct 6, 2019 •
edited
Loading

Thanks for the PR ❤️.

I will release once I get home. Feel free to ping me if I forget.

@ehmicky ehmicky deleted the fix/worker-threads branch October 6, 2019 16:14
@ehmicky
Copy link
Contributor Author

ehmicky commented Oct 6, 2019

Thanks @satazor!

@satazor
Copy link
Contributor

satazor commented Oct 7, 2019

@ehmicky v7.0.1 released, go test it!

@fannheyward fannheyward mentioned this pull request Dec 26, 2019
Closed
@Lakitna Lakitna mentioned this pull request Apr 3, 2020
Closed
@ehmicky ehmicky mentioned this pull request Apr 3, 2020
Merged
satazor pushed a commit that referenced this pull request Nov 18, 2024
@ehmicky @satazor
fix(core): support worker threads (#127)
f4af31c
gurus00 added a commit to gurus00/node-cross-spawn that referenced this pull request Feb 11, 2025
@gurus00
fix(core): support worker threads (moxystudio#127)
cf0c483
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Thompson1985 Thompson1985 Thompson1985 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not work inside workers threads
3 participants
@ehmicky @satazor @Thompson1985