fix: cmd-shim not identified if placed outside node_modules/.bin/
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xximwon
approved these changes
Dec 13, 2024
xximwon
approved these changes
Dec 13, 2024
xximwon
approved these changes
Dec 13, 2024
818Nawaf
approved these changes
Dec 16, 2024
|
Revisiting this, I realize the I'll leave it to the project devs to decide what to do with this PR. |
xximwon
approved these changes
Dec 21, 2024
xximwon
approved these changes
Dec 21, 2024
818Nawaf
approved these changes
Dec 22, 2024
xximwon
approved these changes
Dec 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a node executable installed globally with
npm i -g. Because of this, the cmd-shim was not placed innode_modules/.bin/. On Windows, this causedcross-spawnto escape arguments only once.This PR inspects the contents of the target file and if it can obtain the wrapped command, it will take it as cmd-shim and escape arguments twice.