Replaced deprecated neutrino config with updated webpack config #540
Conversation
✅ Deploy Preview for firefox-performance-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Great to see progress here. It looks like the deploy is failing with:
Is the idea to keep this PR open until tests/deploy are passing? If so, perhaps we should convert it to a draft until it's ready to land? I'll also remove myself from the reviewers as I don't feel qualified to review these changes. |
Carla-Moz
changed the title
@davehunt Yes! It's a WIP so I'll be handling the rest of the errors. Once, it's in a good place, I'll remove the WIP flag. I wanted to put it up now to give visibility to work I'm doing on it. |
There was a problem hiding this comment.
Thanks for these updates!
I pointed out some suggestions and problems. The biggest problems is that the tests don't run :-) and when run they are failing.
But IMO it's fine to have tests failing for now, while you're working on fixing things.
Before landing, I think this should be done:
- simplify the webpack configuration by having just one file and use process.env.NODE_ENV, and get the configuration right
- get tests running (but failing)
- figure out which of .nvmrc or the node_version in netlify.toml is needed and keep one of them if both work (I don't mind which one, I'll let you decide)
The other suggestions can be done in follow-ups IMO.
eslintrc and netlify cleanup restor html plugin config and public folder fix build output for netlify return output to webpack return build command eslintrc and netlify cleanup
Carla-Moz
force-pushed
the
replace-neutrino-with-webpack
branch
from
74844a1 to
9891dc0
Compare
Carla-Moz
changed the title
The best way to reduce the number of critical dependency errors was to remove the deprecated neutrino config and replace it with a normal webpack config. Other changes included changing the jest and eslint config since they also used neutrino. Will continue to work on both in this PR to get the dashboards closer to something more modern and stable. For now, the app runs locally at the port 5000 and the netlify deploy is fixed.
Updates: