For #9830: Do not request/use WRITE_EXTERNAL_STORAGE on Android 11 and above

[czlucius]

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

[czlucius]

Here is the issue for this PR: #9830

[Amejia481]

Tests were not running because of this issue #10776 as d2aa609 landed they should run now :)

[Amejia481]

I updated the tests a bit as we can do it as normal JVM tests, I also waiting for #10778 to be addressed as we are not able run tests for this PR until is fixed.

[mergify]

This pull request has conflicts when rebasing. Could you fix it @czlucius? 🙏

[czlucius]

I updated the tests a bit as we can do it as normal JVM tests, I also waiting for #10778 to be addressed as we are not able run tests for this PR until is fixed.

It seems like the tests are working already.

[Amejia481]

Not really :(,
The release engineering team has closed multiple issues but still they are not running. The source of the issue is that your fork repo is renamed mozilla-android-components instead of the default name android-components, I'm not sure if it will be easier to just rename your fork repo and open a new PR. What do you think?

[Amejia481]

Now tests are running 🙌🏽

[Amejia481]

Now we just need to address, this import lint

task 2021-08-12T17:28:14.050Z] > Task :ktlint
[task 2021-08-12T17:28:14.050Z] WARNING: An illegal reflective access operation has occurred
[task 2021-08-12T17:28:14.050Z] WARNING: Illegal reflective access by org.jetbrains.kotlin.com.intellij.util.ReflectionUtil (file:/builds/worker/fetches/android-gradle-dependencies/central/org/jetbrains/kotlin/kotlin-compiler-embeddable/1.4.31/kotlin-compiler-embeddable-1.4.31.jar) to method java.util.ResourceBundle.setParent(java.util.ResourceBundle)
[task 2021-08-12T17:28:14.050Z] WARNING: Please consider reporting this to the maintainers of org.jetbrains.kotlin.com.intellij.util.ReflectionUtil
[task 2021-08-12T17:28:14.050Z] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
[task 2021-08-12T17:28:14.050Z] WARNING: All illegal access operations will be denied in a future release
[task 2021-08-12T17:28:15.947Z] /builds/worker/checkouts/src/components/feature/downloads/src/test/java/mozilla/components/feature/downloads/manager/AndroidDownloadManagerTest.kt:7:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
[task 2021-08-12T17:28:15.947Z] /builds/worker/checkouts/src/components/feature/downloads/src/test/java/mozilla/components/feature/downloads/manager/FetchDownloadManagerTest.kt:7:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
[task 2021-08-12T17:28:16.251Z] /builds/worker/checkouts/src/components/feature/downloads/src/main/java/mozilla/components/feature/downloads/manager/AndroidDownloadManager.kt:7:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

[Amejia481]

As scoped storage is available in Android 10, we don't need to require it on Android 10 and above

[Amejia481]

I did some manual testing and everything looks good 👍🏽 .
I'll wait until Monday to land this patch, as we avoid landing features over the weekend.

[czlucius]

Not really :(,
The release engineering team has closed multiple issues but still they are not running. The source of the issue is that your fork repo is renamed mozilla-android-components instead of the default name android-components, I'm not sure if it will be easier to just rename your fork repo and open a new PR. What do you think?

I can rename it back if necessary

[czlucius]

I did some manual testing and everything looks good 👍🏽 .
I'll wait until Monday to land this patch, as we avoid landing features over the weekend.

Thanks

[czlucius]

Do the list fixes to the code still need to be made?

[Amejia481]

Do the list fixes to the code still need to be made?

Thanks for asking, they are already addressed. The patch is on is way to be merged :)

[Amejia481]

Thanks @czlucius for all your effort 🥇 !

[czlucius]

Do the list fixes to the code still need to be made?

Sorry, I made a typo. I meant "lint" fixes

[Amejia481]

Do the list fixes to the code still need to be made?

Sorry, I made a typo. I meant "lint" fixes

No worries, they are also addressed :)