Bugfix FXIOS-5112 [v108] Fix Learn More button in ETP settings showing up in wrong places #12227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmarceau
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #12179
This bug was happening because when you tapped Standard option it would lose the label constraint reference for the button and it would still shows up. The only way that I thought that would be a quick and effective solution would take the creation of the UIButton out of the footer function and let it be private inside of the class so I could hide and show the button when check the Standard and Strict button inside of the generateSettings function.
A few other things that I tried was doing some rules to just create the button based on the currentBlockingStrength and/or section but would still happen.