Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bugfix FXIOS-5123 [v107.1] Fix jump back in crash #12369

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Bugfix FXIOS-5123 [v107.1] Fix jump back in crash #12369

merged 2 commits into from
Nov 14, 2022

Conversation

OrlaM
Copy link
Contributor

@OrlaM OrlaM commented Nov 14, 2022 •
edited
Loading

#12188
FXIOS-5123

I'm still not sure why this is crashing but this PR entirely removes the code path of the crash so hopefully it won't just pop up elsewhere.
The call to getLatestData that I removed is redundant in this instance because the data would have been set when the update was initially triggered. Ideally this is the only place where the data is updated so I have removed the convenience method to remove the temptation to call it mid update cycle in future.

@OrlaM OrlaM force-pushed the om/FXIOS-5123-jump-back-in-crash branch from 9f95e01 to 8b21646 Compare November 14, 2022 21:52
@OrlaM
Copy link
Contributor Author

OrlaM commented Nov 14, 2022

Build is green on BR
image

@OrlaM OrlaM merged commit ce903aa into mozilla-mobile:main Nov 14, 2022
@OrlaM OrlaM deleted the om/FXIOS-5123-jump-back-in-crash branch November 14, 2022 22:20
OrlaM added a commit that referenced this pull request Nov 17, 2022
@OrlaM
Bugfix FXIOS-5123 [v107.1] Fix jump back in crash (#12369)
cad563c 
* Fix jump back in crash

* Fix tests
# Conflicts:
#	Tests/ClientTests/Frontend/Home/JumpBackIn/JumpBackInViewModelTests.swift
OrlaM added a commit that referenced this pull request Nov 25, 2022
@OrlaM
Bugfix FXIOS-5123 [v107.1] Fix jump back in crash (#12369)
ead4eb7 
* Fix jump back in crash

* Fix tests
# Conflicts:
#	Tests/ClientTests/Frontend/Home/JumpBackIn/JumpBackInViewModelTests.swift

# Conflicts:
#	Tests/ClientTests/Frontend/Home/JumpBackIn/JumpBackInViewModelTests.swift
lillabldv added a commit to karmaSearch/iOS-browser that referenced this pull request Feb 27, 2023
@lillabldv
Merge commit '5e4af50e8fae12e48f0821276ae041e717e4c22f'
a25ca9b 
* commit '5e4af50e8fae12e48f0821276ae041e717e4c22f': (1088 commits)
  Bugfix FXIOS-5293 [v107.2] Remove site image helper from data adaptors for 107.2 (mozilla-mobile#12448)
  Bugfix FXIOS-5294 [v107.2] Removing further database favicons calls (mozilla-mobile#12444)
  Bump to v107.2
  Only send fatal errors to sentry (mozilla-mobile#12419)
  Bugfix FXIOS-5123 [v107.1] Fix jump back in crash (mozilla-mobile#12369)
  Bugfix FXIOS-5244 [v107.1] LPMetaDataProvider crash (mozilla-mobile#12371)
  Bugfix FXIOS-5245 [v107.1] Add a safety check and track warning in Authenticator (mozilla-mobile#12373)
  Update version number to 107.1
  Bugfix FXIOS-5164 [v107] favicon fix (mozilla-mobile#12353)
  Bugfix FXIOS-5223 [v107] Fix migration error (mozilla-mobile#12350)
  Localize [v107] String import 2022-11-07 (mozilla-mobile#12333)
  Bugfix FXIOS-5197 [v107] Fix inactive tabs on update issue (mozilla-mobile#12323)
  Bugfix FXIOS-5208 [v107] Change top sites design (mozilla-mobile#12317)
  Update package.resolved file for glean update
  Refactor FXIOS-5149 [v108] Put back recent tabs on main thread (mozilla-mobile#12312)
  Refactor FXIOS-5149 [v108] Jump back in data refresh (mozilla-mobile#12290)
  Bugfix FXIOS-5123 [v106.1] Change order of operations for reloading homepage (mozilla-mobile#12224)
  Bugfix FXIOS-4855 Update Glean version to v51.8.0 (mozilla-mobile#12311)
  Bugfix FXIOS-4855 [v106.1] Update glean version to 51.7.0 (mozilla-mobile#12223)
  Add FXIOS-5198 [v107] Track memory warning (mozilla-mobile#12292)
  ...

# Conflicts:
#	Cartfile
#	Cartfile.resolved
#	Client.xcodeproj/project.pbxproj
#	Client.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	Client/Application/AppDelegate+PushNotifications.swift
#	Client/Application/AppDelegate.swift
#	Client/Application/NavigationRouter.swift
#	Client/Assets/Search/SearchPlugins/list.json
#	Client/Experiments/NimbusFeatures.swift
#	Client/Extensions/UIImageViewExtensions.swift
#	Client/FeatureFlags/FlaggableFeature.swift
#	Client/Frontend/Browser/BrowserTrayAnimators.swift
#	Client/Frontend/Browser/BrowserViewController.swift
#	Client/Frontend/Browser/BrowserViewController/BrowserViewController+KeyCommands.swift
#	Client/Frontend/Browser/BrowserViewController/BrowserViewController+TabToolbarDelegate.swift
#	Client/Frontend/Browser/BrowserViewController/BrowserViewController+URLBarDelegate.swift
#	Client/Frontend/Browser/GridTabViewController.swift
#	Client/Frontend/Browser/QRCodeViewController.swift
#	Client/Frontend/Browser/ScreenshotHelper.swift
#	Client/Frontend/Browser/SearchViewController.swift
#	Client/Frontend/Browser/SiteArchiver.swift
#	Client/Frontend/Browser/Tab Management/Tab.swift
#	Client/Frontend/Browser/TabLocationView.swift
#	Client/Frontend/Browser/Tabs/ChronologicalTabsViewController.swift
#	Client/Frontend/Browser/Tabs/EmptyPrivateTabsView.swift
#	Client/Frontend/Browser/Tabs/InactiveTabCell.swift
#	Client/Frontend/Browser/Tabs/TabMoreMenuHeader.swift
#	Client/Frontend/Browser/Tabs/TabTrayViewController.swift
#	Client/Frontend/Browser/Tabs/TabTrayViewModel.swift
#	Client/Frontend/Browser/TopSitesManager.swift
#	Client/Frontend/DefaultBrowserOnboarding/DefaultBrowserOnboardingViewController.swift
#	Client/Frontend/DefaultBrowserOnboarding/DefaultBrowserOnboardingViewModel.swift
#	Client/Frontend/EnhancedTrackingProtection/ETPCoverSheetViewController.swift
#	Client/Frontend/Home/ASHeaderView.swift
#	Client/Frontend/Home/DefaultBrowserCard.swift
#	Client/Frontend/Home/FirefoxHomeTopSitesCell.swift
#	Client/Frontend/Home/FxHomeJumpBackInView.swift
#	Client/Frontend/Home/FxHomeRecentlySavedCollectionCell.swift
#	Client/Frontend/Home/KarmaHomeViewController.swift
#	Client/Frontend/Home/LibraryShortcutView.swift
#	Client/Frontend/Intro/IntroScreenWelcomeView.swift
#	Client/Frontend/Intro/IntroViewController.swift
#	Client/Frontend/Library/LibraryPanelButton.swift
#	Client/Frontend/Library/LibraryPanelContextMenu.swift
#	Client/Frontend/Library/LibraryViewController/LibraryViewController.swift
#	Client/Frontend/Settings/AppSettingsOptions.swift
#	Client/Frontend/Settings/AppSettingsTableViewController.swift
#	Client/Frontend/Settings/ContentBlockerSettingViewController.swift
#	Client/Frontend/Settings/HomePageSettingViewController.swift
#	Client/Frontend/Settings/SettingsNavigationController.swift
#	Client/Frontend/Strings.swift
#	Client/Frontend/Theme/LegacyThemeManager/LegacyDarkTheme.swift
#	Client/Frontend/Theme/LegacyThemeManager/LegacyTheme.swift
#	Client/Frontend/Theme/LegacyThemeManager/ThemedWidgets.swift
#	Client/Frontend/Toolbar+URLBar/TabToolbarHelper.swift
#	Client/Frontend/Toolbar+URLBar/URLBarView.swift
#	Client/Frontend/Update/UpdateCoverSheetTableViewCell.swift
#	Client/Frontend/Update/UpdateViewController.swift
#	Client/Frontend/Widgets/GradientProgressBar.swift
#	Client/Frontend/Widgets/OneLineCellAndFooter.swift
#	Client/Frontend/Widgets/PhotonActionSheet/AppMenu.swift
#	Client/Frontend/Widgets/PhotonActionSheet/PageActionMenu.swift
#	Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheet.swift
#	Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetCell.swift
#	Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetProtocol.swift
#	Client/Frontend/Widgets/PhotonActionSheet/PhotonActionSheetWidgets.swift
#	Client/Frontend/Widgets/SiteTableViewController.swift
#	Client/Frontend/Widgets/TwoLineCellAndFooter.swift
#	Client/Info.plist
#	Client/Telemetry/TelemetryWrapper.swift
#	Client/co.lproj/InfoPlist.strings
#	Client/en.lproj/InfoPlist.strings
#	Client/fr.lproj/InfoPlist.strings
#	Client/ia.lproj/InfoPlist.strings
#	Client/id.lproj/InfoPlist.strings
#	Client/ka.lproj/InfoPlist.strings
#	Client/ne-NP.lproj/InfoPlist.strings
#	Client/zh-CN.lproj/InfoPlist.strings
#	ClientTests/FirefoxHomeTests.swift
#	CredentialProvider/Cells/EmptyPlaceholderCell.swift
#	CredentialProvider/Cells/ItemListCell.swift
#	CredentialProvider/Cells/NoSearchResultCell.swift
#	CredentialProvider/Cells/SelectPasswordCell.swift
#	CredentialProvider/CredentialListPresenter.swift
#	CredentialProvider/CredentialListViewController.swift
#	CredentialProvider/CredentialPasscodeRequirementViewController.swift
#	CredentialProvider/CredentialProviderPresenter.swift
#	CredentialProvider/CredentialProviderViewController.swift
#	CredentialProvider/CredentialWelcomeViewController.swift
#	CredentialProvider/Extensions/AlertControllerView.swift
#	CredentialProvider/Extensions/UIColorExtension.swift
#	CredentialProvider/Extensions/UIFontExtension.swift
#	CredentialProvider/Extensions/UIImageExtension.swift
#	CredentialProvider/Info.plist
#	Extensions/NotificationService/Info.plist
#	Extensions/ShareTo/Info.plist
#	Extensions/Today/ButtonWithSublabel.swift
#	Extensions/Today/ImageButtonWithLabel.swift
#	Extensions/Today/Info.plist
#	Extensions/Today/TodayModel.swift
#	Extensions/Today/TodayUX.swift
#	Extensions/Today/TodayViewController.swift
#	Extensions/Today/TodayViewModel.swift
#	Extensions/Today/UIButtonExtensions.swift
#	Info.plist
#	README.md
#	Shared/AppConstants.swift
#	Shared/UserAgent.swift
#	Shared/af.lproj/Localizable.strings
#	Shared/an.lproj/3DTouchActions.strings
#	Shared/an.lproj/Default Browser.strings
#	Shared/an.lproj/Intro.strings
#	Shared/an.lproj/Localizable.strings
#	Shared/an.lproj/Menu.strings
#	Shared/an.lproj/Today.strings
#	Shared/anp.lproj/3DTouchActions.strings
#	Shared/anp.lproj/Default Browser.strings
#	Shared/anp.lproj/Localizable.strings
#	Shared/ar.lproj/3DTouchActions.strings
#	Shared/ar.lproj/Default Browser.strings
#	Shared/ar.lproj/Intro.strings
#	Shared/ar.lproj/Localizable.strings
#	Shared/ar.lproj/Menu.strings
#	Shared/ar.lproj/Today.strings
#	Shared/ast.lproj/Default Browser.strings
#	Shared/ast.lproj/Intro.strings
#	Shared/ast.lproj/Localizable.strings
#	Shared/ast.lproj/Menu.strings
#	Shared/ast.lproj/Today.strings
#	Shared/az.lproj/3DTouchActions.strings
#	Shared/az.lproj/Default Browser.strings
#	Shared/az.lproj/Intro.strings
#	Shared/az.lproj/Localizable.strings
#	Shared/az.lproj/Menu.strings
#	Shared/bg.lproj/3DTouchActions.strings
#	Shared/bg.lproj/Intro.strings
#	Shared/bg.lproj/Localizable.strings
#	Shared/bg.lproj/Today.strings
#	Shared/bn.lproj/3DTouchActions.strings
#	Shared/bn.lproj/Default Browser.strings
#	Shared/bn.lproj/Intro.strings
#	Shared/bn.lproj/Localizable.strings
#	Shared/bn.lproj/Menu.strings
#	Shared/bn.lproj/Today.strings
#	Shared/br.lproj/3DTouchActions.strings
#	Shared/br.lproj/Default Browser.strings
#	Shared/br.lproj/Intro.strings
#	Shared/br.lproj/Localizable.strings
#	Shared/br.lproj/Menu.strings
#	Shared/br.lproj/Today.strings
#	Shared/bs.lproj/3DTouchActions.strings
#	Shared/bs.lproj/Localizable.strings
#	Shared/ca.lproj/3DTouchActions.strings
#	Shared/ca.lproj/Default Browser.strings
#	Shared/ca.lproj/Intro.strings
#	Shared/ca.lproj/Localizable.strings
#	Shared/ca.lproj/Menu.strings
#	Shared/ca.lproj/Today.strings
#	Shared/co.lproj/3DTouchActions.strings
#	Shared/co.lproj/Default Browser.strings
#	Shared/co.lproj/Intro.strings
#	Shared/co.lproj/Localizable.strings
#	Shared/co.lproj/Menu.strings
#	Shared/co.lproj/PrivateBrowsing.strings
#	Shared/co.lproj/Today.strings
#	Shared/cs.lproj/3DTouchActions.strings
#	Shared/cs.lproj/Default Browser.strings
#	Shared/cs.lproj/Intro.strings
#	Shared/cs.lproj/Localizable.strings
#	Shared/cs.lproj/Menu.strings
#	Shared/cs.lproj/Today.strings
#	Shared/cy.lproj/3DTouchActions.strings
#	Shared/cy.lproj/Default Browser.strings
#	Shared/cy.lproj/Intro.strings
#	Shared/cy.lproj/Localizable.strings
#	Shared/cy.lproj/Menu.strings
#	Shared/cy.lproj/Today.strings
#	Shared/da.lproj/3DTouchActions.strings
#	Shared/da.lproj/Default Browser.strings
#	Shared/da.lproj/Intro.strings
#	Shared/da.lproj/Localizable.strings
#	Shared/da.lproj/Menu.strings
#	Shared/da.lproj/Today.strings
#	Shared/de.lproj/3DTouchActions.strings
#	Shared/de.lproj/Default Browser.strings
#	Shared/de.lproj/Intro.strings
#	Shared/de.lproj/Localizable.strings
#	Shared/de.lproj/Menu.strings
#	Shared/de.lproj/Today.strings
#	Shared/dsb.lproj/3DTouchActions.strings
#	Shared/dsb.lproj/Default Browser.strings
#	Shared/dsb.lproj/Intro.strings
#	Shared/dsb.lproj/Localizable.strings
#	Shared/dsb.lproj/Menu.strings
#	Shared/dsb.lproj/Today.strings
#	Shared/el.lproj/3DTouchActions.strings
#	Shared/el.lproj/Default Browser.strings
#	Shared/el.lproj/Intro.strings
#	Shared/el.lproj/Localizable.strings
#	Shared/el.lproj/Menu.strings
#	Shared/el.lproj/Today.strings
#	Shared/en-CA.lproj/3DTouchActions.strings
#	Shared/en-CA.lproj/Default Browser.strings
#	Shared/en-CA.lproj/Intro.strings
#	Shared/en-CA.lproj/Localizable.strings
#	Shared/en-CA.lproj/Menu.strings
#	Shared/en-CA.lproj/Today.strings
#	Shared/en-GB.lproj/3DTouchActions.strings
#	Shared/en-GB.lproj/Default Browser.strings
#	Shared/en-GB.lproj/Intro.strings
#	Shared/en-GB.lproj/Localizable.strings
#	Shared/en-GB.lproj/Menu.strings
#	Shared/en-GB.lproj/Today.strings
#	Shared/en.lproj/3DTouchActions.strings
#	Shared/en.lproj/Default Browser.strings
#	Shared/en.lproj/Intro.strings
#	Shared/en.lproj/Localizable.strings
#	Shared/en.lproj/Menu.strings
#	Shared/en.lproj/PrivateBrowsing.strings
#	Shared/en.lproj/Search.strings
#	Shared/en.lproj/Today.strings
#	Shared/eo.lproj/3DTouchActions.strings
#	Shared/eo.lproj/Default Browser.strings
#	Shared/eo.lproj/Intro.strings
#	Shared/eo.lproj/Localizable.strings
#	Shared/eo.lproj/Menu.strings
#	Shared/eo.lproj/Today.strings
#	Shared/es-AR.lproj/3DTouchActions.strings
#	Shared/es-AR.lproj/Default Browser.strings
#	Shared/es-AR.lproj/Intro.strings
#	Shared/es-AR.lproj/Localizable.strings
#	Shared/es-AR.lproj/Menu.strings
#	Shared/es-AR.lproj/Today.strings
#	Shared/es-CL.lproj/3DTouchActions.strings
#	Shared/es-CL.lproj/Default Browser.strings
#	Shared/es-CL.lproj/Intro.strings
#	Shared/es-CL.lproj/Localizable.strings
#	Shared/es-CL.lproj/Menu.strings
#	Shared/es-CL.lproj/Today.strings
#	Shared/es-MX.lproj/3DTouchActions.strings
#	Shared/es-MX.lproj/Default Browser.strings
#	Shared/es-MX.lproj/Intro.strings
#	Shared/es-MX.lproj/Localizable.strings
#	Shared/es-MX.lproj/Menu.strings
#	Shared/es-MX.lproj/Today.strings
#	Shared/es.lproj/3DTouchActions.strings
#	Shared/es.lproj/Default Browser.strings
#	Shared/es.lproj/Intro.strings
#	Shared/es.lproj/Localizable.strings
#	Shared/es.lproj/Menu.strings
#	Shared/es.lproj/Today.strings
#	Shared/eu.lproj/3DTouchActions.strings
#	Shared/eu.lproj/Default Browser.strings
#	Shared/eu.lproj/Intro.strings
#	Shared/eu.lproj/Localizable.strings
#	Shared/eu.lproj/Menu.strings
#	Shared/eu.lproj/Today.strings
#	Shared/fa.lproj/3DTouchActions.strings
#	Shared/fa.lproj/Default Browser.strings
#	Shared/fa.lproj/Intro.strings
#	Shared/fa.lproj/Localizable.strings
#	Shared/fa.lproj/Menu.strings
#	Shared/fa.lproj/Today.strings
#	Shared/fi.lproj/3DTouchActions.strings
#	Shared/fi.lproj/Default Browser.strings
#	Shared/fi.lproj/Intro.strings
#	Shared/fi.lproj/Localizable.strings
#	Shared/fi.lproj/Menu.strings
#	Shared/fi.lproj/Today.strings
#	Shared/fil.lproj/3DTouchActions.strings
#	Shared/fil.lproj/Intro.strings
#	Shared/fil.lproj/Localizable.strings
#	Shared/fil.lproj/Menu.strings
#	Shared/fr.lproj/3DTouchActions.strings
#	Shared/fr.lproj/AuthenticationManager.strings
#	Shared/fr.lproj/Default Browser.strings
#	Shared/fr.lproj/Intro.strings
#	Shared/fr.lproj/Localizable.strings
#	Shared/fr.lproj/Menu.strings
#	Shared/fr.lproj/Search.strings
#	Shared/fr.lproj/Today.strings
#	Shared/ga.lproj/3DTouchActions.strings
#	Shared/ga.lproj/Localizable.strings
#	Shared/gd.lproj/3DTouchActions.strings
#	Shared/gd.lproj/Default Browser.strings
#	Shared/gd.lproj/Intro.strings
#	Shared/gd.lproj/Localizable.strings
#	Shared/gd.lproj/Menu.strings
#	Shared/gd.lproj/Today.strings
#	Shared/gl.lproj/3DTouchActions.strings
#	Shared/gl.lproj/Intro.strings
#	Shared/gl.lproj/Localizable.strings
#	Shared/gu-IN.lproj/3DTouchActions.strings
#	Shared/gu-IN.lproj/Intro.strings
#	Shared/gu-IN.lproj/Localizable.strings
#	Shared/gu-IN.lproj/Menu.strings
#	Shared/he.lproj/3DTouchActions.strings
#	Shared/he.lproj/Default Browser.strings
#	Shared/he.lproj/Intro.strings
#	Shared/he.lproj/Localizable.strings
#	Shared/he.lproj/Menu.strings
#	Shared/he.lproj/Today.strings
#	Shared/hi-IN.lproj/3DTouchActions.strings
#	Shared/hi-IN.lproj/Default Browser.strings
#	Shared/hi-IN.lproj/Intro.strings
#	Shared/hi-IN.lproj/Localizable.strings
#	Shared/hi-IN.lproj/Menu.strings
#	Shared/hi-IN.lproj/Today.strings
#	Shared/hr.lproj/3DTouchActions.strings
#	Shared/hr.lproj/Default Browser.strings
#	Shared/hr.lproj/Intro.strings
#	Shared/hr.lproj/Localizable.strings
#	Shared/hr.lproj/Menu.strings
#	Shared/hr.lproj/Today.strings
#	Shared/hsb.lproj/3DTouchActions.strings
#	Shared/hsb.lproj/Default Browser.strings
#	Shared/hsb.lproj/Intro.strings
#	Shared/hsb.lproj/Localizable.strings
#	Shared/hsb.lproj/Menu.strings
#	Shared/hsb.lproj/Today.strings
#	Shared/hu.lproj/3DTouchActions.strings
#	Shared/hu.lproj/Default Browser.strings
#	Shared/hu.lproj/Intro.strings
#	Shared/hu.lproj/Localizable.strings
#	Shared/hu.lproj/Menu.strings
#	Shared/hu.lproj/Today.strings
#	Shared/hy-AM.lproj/3DTouchActions.strings
#	Shared/hy-AM.lproj/Default Browser.strings
#	Shared/hy-AM.lproj/Intro.strings
#	Shared/hy-AM.lproj/Localizable.strings
#	Shared/hy-AM.lproj/Menu.strings
#	Shared/hy-AM.lproj/Today.strings
#	Shared/ia.lproj/3DTouchActions.strings
#	Shared/ia.lproj/Default Browser.strings
#	Shared/ia.lproj/Intro.strings
#	Shared/ia.lproj/Localizable.strings
#	Shared/ia.lproj/Menu.strings
#	Shared/ia.lproj/Today.strings
#	Shared/id.lproj/3DTouchActions.strings
#	Shared/id.lproj/Default Browser.strings
#	Shared/id.lproj/Intro.strings
#	Shared/id.lproj/Localizable.strings
#	Shared/id.lproj/Menu.strings
#	Shared/id.lproj/Today.strings
#	Shared/is.lproj/3DTouchActions.strings
#	Shared/is.lproj/Intro.strings
#	Shared/is.lproj/Localizable.strings
#	Shared/is.lproj/PrivateBrowsing.strings
#	Shared/it.lproj/3DTouchActions.strings
#	Shared/it.lproj/Default Browser.strings
#	Shared/it.lproj/Intro.strings
#	Shared/it.lproj/Localizable.strings
#	Shared/it.lproj/Menu.strings
#	Shared/it.lproj/Today.strings
#	Shared/ja.lproj/3DTouchActions.strings
#	Shared/ja.lproj/Default Browser.strings
#	Shared/ja.lproj/Intro.strings
#	Shared/ja.lproj/Localizable.strings
#	Shared/ja.lproj/Menu.strings
#	Shared/ja.lproj/Today.strings
#	Shared/jv.lproj/3DTouchActions.strings
#	Shared/jv.lproj/Localizable.strings
#	Shared/ka.lproj/3DTouchActions.strings
#	Shared/ka.lproj/Default Browser.strings
#	Shared/ka.lproj/Intro.strings
#	Shared/ka.lproj/Localizable.strings
#	Shared/ka.lproj/Menu.strings
#	Shared/ka.lproj/Today.strings
#	Shared/kab.lproj/3DTouchActions.strings
#	Shared/kab.lproj/Default Browser.strings
#	Shared/kab.lproj/Intro.strings
#	Shared/kab.lproj/Localizable.strings
#	Shared/kab.lproj/Menu.strings
#	Shared/kab.lproj/Today.strings
#	Shared/kk.lproj/3DTouchActions.strings
#	Shared/kk.lproj/Default Browser.strings
#	Shared/kk.lproj/Intro.strings
#	Shared/kk.lproj/Localizable.strings
#	Shared/kk.lproj/Menu.strings
#	Shared/kk.lproj/Today.strings
#	Shared/km.lproj/3DTouchActions.strings
#	Shared/km.lproj/Default Browser.strings
#	Shared/km.lproj/Intro.strings
#	Shared/km.lproj/Localizable.strings
#	Shared/km.lproj/Menu.strings
#	Shared/kn.lproj/3DTouchActions.strings
#	Shared/kn.lproj/Localizable.strings
#	Shared/ko.lproj/3DTouchActions.strings
#	Shared/ko.lproj/Default Browser.strings
#	Shared/ko.lproj/Intro.strings
#	Shared/ko.lproj/Localizable.strings
#	Shared/ko.lproj/Menu.strings
#	Shared/ko.lproj/Today.strings
#	Shared/lo.lproj/3DTouchActions.strings
#	Shared/lo.lproj/Default Browser.strings
#	Shared/lo.lproj/Intro.strings
#	Shared/lo.lproj/Localizable.strings
#	Shared/lo.lproj/Menu.strings
#	Shared/lo.lproj/Today.strings
#	Shared/lt.lproj/3DTouchActions.strings
#	Shared/lt.lproj/Default Browser.strings
#	Shared/lt.lproj/Intro.strings
#	Shared/lt.lproj/Localizable.strings
#	Shared/lt.lproj/Menu.strings
#	Shared/lt.lproj/Today.strings
#	Shared/lv.lproj/3DTouchActions.strings
#	Shared/lv.lproj/Intro.strings
#	Shared/lv.lproj/Localizable.strings
#	Shared/ml.lproj/3DTouchActions.strings
#	Shared/ml.lproj/Intro.strings
#	Shared/ml.lproj/Localizable.strings
#	Shared/ml.lproj/Menu.strings
#	Shared/mr.lproj/3DTouchActions.strings
#	Shared/mr.lproj/Default Browser.strings
#	Shared/mr.lproj/Intro.strings
#	Shared/mr.lproj/Localizable.strings
#	Shared/mr.lproj/Menu.strings
#	Shared/ms.lproj/3DTouchActions.strings
#	Shared/ms.lproj/Intro.strings
#	Shared/ms.lproj/Localizable.strings
#	Shared/my.lproj/3DTouchActions.strings
#	Shared/my.lproj/Default Browser.strings
#	Shared/my.lproj/Intro.strings
#	Shared/my.lproj/Localizable.strings
#	Shared/my.lproj/Menu.strings
#	Shared/my.lproj/Today.strings
#	Shared/nb.lproj/3DTouchActions.strings
#	Shared/nb.lproj/Default Browser.strings
#	Shared/nb.lproj/Intro.strings
#	Shared/nb.lproj/Localizable.strings
#	Shared/nb.lproj/Menu.strings
#	Shared/nb.lproj/Today.strings
#	Shared/ne-NP.lproj/3DTouchActions.strings
#	Shared/ne-NP.lproj/Default Browser.strings
#	Shared/ne-NP.lproj/Intro.strings
#	Shared/ne-NP.lproj/Localizable.strings
#	Shared/nl.lproj/3DTouchActions.strings
#	Shared/nl.lproj/Default Browser.strings
#	Shared/nl.lproj/Intro.strings
#	Shared/nl.lproj/Localizable.strings
#	Shared/nl.lproj/Menu.strings
#	Shared/nl.lproj/Today.strings
#	Shared/nn.lproj/3DTouchActions.strings
#	Shared/nn.lproj/Default Browser.strings
#	Shared/nn.lproj/Intro.strings
#	Shared/nn.lproj/Localizable.strings
#	Shared/nn.lproj/Menu.strings
#	Shared/nn.lproj/Today.strings
#	Shared/oc.lproj/3DTouchActions.strings
#	Shared/oc.lproj/Intro.strings
#	Shared/oc.lproj/Localizable.strings
#	Shared/oc.lproj/Menu.strings
#	Shared/or.lproj/3DTouchActions.strings
#	Shared/or.lproj/Localizable.strings
#	Shared/pa-IN.lproj/3DTouchActions.strings
#	Shared/pa-IN.lproj/Default Browser.strings
#	Shared/pa-IN.lproj/Intro.strings
#	Shared/pa-IN.lproj/Localizable.strings
#	Shared/pa-IN.lproj/Menu.strings
#	Shared/pa-IN.lproj/Today.strings
#	Shared/pl.lproj/3DTouchActions.strings
#	Shared/pl.lproj/Default Browser.strings
#	Shared/pl.lproj/Intro.strings
#	Shared/pl.lproj/Localizable.strings
#	Shared/pl.lproj/Menu.strings
#	Shared/pl.lproj/Today.strings
#	Shared/pt-BR.lproj/3DTouchActions.strings
#	Shared/pt-BR.lproj/Default Browser.strings
#	Shared/pt-BR.lproj/Intro.strings
#	Shared/pt-BR.lproj/Localizable.strings
#	Shared/pt-BR.lproj/Menu.strings
#	Shared/pt-BR.lproj/Today.strings
#	Shared/pt-PT.lproj/3DTouchActions.strings
#	Shared/pt-PT.lproj/Default Browser.strings
#	Shared/pt-PT.lproj/Intro.strings
#	Shared/pt-PT.lproj/Localizable.strings
#	Shared/pt-PT.lproj/Menu.strings
#	Shared/pt-PT.lproj/Today.strings
#	Shared/rm.lproj/3DTouchActions.strings
#	Shared/rm.lproj/Default Browser.strings
#	Shared/rm.lproj/Intro.strings
#	Shared/rm.lproj/Localizable.strings
#	Shared/rm.lproj/Menu.strings
#	Shared/rm.lproj/Today.strings
#	Shared/ro.lproj/3DTouchActions.strings
#	Shared/ro.lproj/Default Browser.strings
#	Shared/ro.lproj/Intro.strings
#	Shared/ro.lproj/Localizable.strings
#	Shared/ro.lproj/Menu.strings
#	Shared/ro.lproj/Today.strings
#	Shared/ru.lproj/3DTouchActions.strings
#	Shared/ru.lproj/Default Browser.strings
#	Shared/ru.lproj/Intro.strings
#	Shared/ru.lproj/Localizable.strings
#	Shared/ru.lproj/Menu.strings
#	Shared/ru.lproj/Today.strings
#	Shared/sat-Olck.lproj/3DTouchActions.strings
#	Shared/sat-Olck.lproj/Default Browser.strings
#	Shared/sat-Olck.lproj/Intro.strings
#	Shared/sat-Olck.lproj/Localizable.strings
#	Shared/sat-Olck.lproj/Menu.strings
#	Shared/sat-Olck.lproj/PrivateBrowsing.strings
#	Shared/sat-Olck.lproj/Today.strings
#	Shared/ses.lproj/3DTouchActions.strings
#	Shared/ses.lproj/Intro.strings
#	Shared/ses.lproj/Localizable.strings
#	Shared/si.lproj/3DTouchActions.strings
#	Shared/si.lproj/Localizable.strings
#	Shared/sk.lproj/3DTouchActions.strings
#	Shared/sk.lproj/Default Browser.strings
#	Shared/sk.lproj/Intro.strings
#	Shared/sk.lproj/Localizable.strings
#	Shared/sk.lproj/Menu.strings
#	Shared/sk.lproj/Today.strings
#	Shared/sl.lproj/3DTouchActions.strings
#	Shared/sl.lproj/Default Browser.strings
#	Shared/sl.lproj/Intro.strings
#	Shared/sl.lproj/Localizable.strings
#	Shared/sl.lproj/Menu.strings
#	Shared/sl.lproj/Today.strings
#	Shared/sq.lproj/3DTouchActions.strings
#	Shared/sq.lproj/Default Browser.strings
#	Shared/sq.lproj/Intro.strings
#	Shared/sq.lproj/Localizable.strings
#	Shared/sq.lproj/Menu.strings
#	Shared/sq.lproj/Today.strings
#	Shared/su.lproj/3DTouchActions.strings
#	Shared/su.lproj/Default Browser.strings
#	Shared/su.lproj/Intro.strings
#	Shared/su.lproj/Localizable.strings
#	Shared/su.lproj/Menu.strings
#	Shared/su.lproj/Today.strings
#	Shared/sv.lproj/3DTouchActions.strings
#	Shared/sv.lproj/Default Browser.strings
#	Shared/sv.lproj/Intro.strings
#	Shared/sv.lproj/Localizable.strings
#	Shared/sv.lproj/Menu.strings
#	Shared/sv.lproj/Today.strings
#	Shared/ta.lproj/3DTouchActions.strings
#	Shared/ta.lproj/Intro.strings
#	Shared/ta.lproj/Localizable.strings
#	Shared/ta.lproj/Menu.strings
#	Shared/te.lproj/3DTouchActions.strings
#	Shared/te.lproj/Default Browser.strings
#	Shared/te.lproj/Intro.strings
#	Shared/te.lproj/Localizable.strings
#	Shared/te.lproj/Today.strings
#	Shared/th.lproj/3DTouchActions.strings
#	Shared/th.lproj/Default Browser.strings
#	Shared/th.lproj/Intro.strings
#	Shared/th.lproj/Localizable.strings
#	Shared/th.lproj/Menu.strings
#	Shared/th.lproj/Today.strings
#	Shared/tr.lproj/3DTouchActions.strings
#	Shared/tr.lproj/Default Browser.strings
#	Shared/tr.lproj/Intro.strings
#	Shared/tr.lproj/Localizable.strings
#	Shared/tr.lproj/Menu.strings
#	Shared/tr.lproj/Today.strings
#	Shared/uk.lproj/3DTouchActions.strings
#	Shared/uk.lproj/Default Browser.strings
#	Shared/uk.lproj/Intro.strings
#	Shared/uk.lproj/Localizable.strings
#	Shared/uk.lproj/Menu.strings
#	Shared/uk.lproj/Today.strings
#	Shared/ur.lproj/3DTouchActions.strings
#	Shared/ur.lproj/Default Browser.strings
#	Shared/ur.lproj/Intro.strings
#	Shared/ur.lproj/Localizable.strings
#	Shared/ur.lproj/Menu.strings
#	Shared/ur.lproj/PrivateBrowsing.strings
#	Shared/ur.lproj/Today.strings
#	Shared/uz.lproj/3DTouchActions.strings
#	Shared/uz.lproj/Localizable.strings
#	Shared/vi.lproj/3DTouchActions.strings
#	Shared/vi.lproj/Default Browser.strings
#	Shared/vi.lproj/Intro.strings
#	Shared/vi.lproj/Localizable.strings
#	Shared/vi.lproj/Menu.strings
#	Shared/vi.lproj/Today.strings
#	Shared/zh-CN.lproj/3DTouchActions.strings
#	Shared/zh-CN.lproj/Default Browser.strings
#	Shared/zh-CN.lproj/Intro.strings
#	Shared/zh-CN.lproj/Localizable.strings
#	Shared/zh-CN.lproj/Menu.strings
#	Shared/zh-CN.lproj/Today.strings
#	Shared/zh-TW.lproj/3DTouchActions.strings
#	Shared/zh-TW.lproj/Default Browser.strings
#	Shared/zh-TW.lproj/Intro.strings
#	Shared/zh-TW.lproj/Localizable.strings
#	Shared/zh-TW.lproj/Menu.strings
#	Shared/zh-TW.lproj/Today.strings
#	WidgetKit/ImageButtonWithLabel.swift
#	WidgetKit/Info.plist
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thatswinnie thatswinnie thatswinnie approved these changes

@lmarceau lmarceau lmarceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrlaM @thatswinnie @lmarceau