Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bug 1488862 debugging CloudHSM failures in stage running 2.2.2, we see requests within 30 seconds of server start or a previous successful request succeed, but those more than 30 seconds later fail with
..."Fields":{"code":500,"msg":"signing failed with error: mar: failed to finalize signature: pkcs11: 0x82: CKR_OBJECT_HANDLE_INVALID","rid":...
While we haven't seen
pkcs11: 0x101: CKR_USER_NOT_LOGGED_IN
errors in stage, this still appears to be due to: ThalesGroup/crypto11#9The HSM dev instance we successfully load tested earlier is on commit 2210ea8, so this PR reverts crypto11 to that commit (regression could be further narrowed down to 2210ea8...2.2.2 too)
We'll need to pin this version if we switch to vgo for #115 too.
r? @jvehent or @ajvb if you're not swamped