Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Update constraints #294

Closed
wants to merge 4 commits into from
Closed

Update constraints #294

wants to merge 4 commits into from

Conversation

leplatrem
Copy link
Collaborator

fixes #291

@leplatrem
Copy link
Collaborator Author

I don't think the error is due to the constraints update

@leplatrem leplatrem requested a review from glasserc October 26, 2018 13:53
glasserc
glasserc approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Precondition failed could be due to transaction. Is it reproducible? Approving because the changes look sane but we should probably make sure everything is OK before merge.

@leplatrem leplatrem closed this Nov 6, 2018
@leplatrem leplatrem deleted the update-constraints branch November 6, 2018 15:11
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@glasserc glasserc glasserc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do I update the requirements/constraints.txt file?
2 participants
@leplatrem @glasserc