Set display CSS property on iframes. (#4148) (#4256)

mozilla-services · Mar 22, 2018 · ba4073f · ba4073f
1 parent 9a5699b
commit ba4073f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/addon/webextension/onboarding/slides.js b/addon/webextension/onboarding/slides.js
@@ -24,6 +24,7 @@ this.slides = (function() {
       iframe.src = browser.extension.getURL("blank.html");
       iframe.id = "firefox-screenshots-onboarding-iframe";
       iframe.style.zIndex = "99999999999";
+      iframe.style.display = "block";
       iframe.style.border = "none";
       iframe.style.position = "fixed";
       iframe.style.top = "0";

diff --git a/addon/webextension/selector/ui.js b/addon/webextension/selector/ui.js
@@ -173,7 +173,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
 
     unhide() {
       this.updateElementSize();
-      this.element.style.display = "";
+      this.element.style.display = "block";
       catcher.watchPromise(callBackground("sendEvent", "internal", "unhide-selection-frame"));
       if (highContrastCheck(this.element.contentWindow)) {
         this.element.contentDocument.body.classList.add("hcm");
@@ -222,7 +222,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
         }
       }
       if (force && visible) {
-        this.element.style.display = "";
+        this.element.style.display = "block";
       }
     },
 
@@ -344,7 +344,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
     unhide() {
       window.addEventListener("scroll", watchFunction(assertIsTrusted(this.onScroll)));
       window.addEventListener("resize", this.onResize, true);
-      this.element.style.display = "";
+      this.element.style.display = "block";
       catcher.watchPromise(callBackground("sendEvent", "internal", "unhide-preselection-frame"));
       if (highContrastCheck(this.element.contentWindow)) {
         this.element.contentDocument.body.classList.add("hcm");
@@ -458,7 +458,7 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
     },
 
     unhide() {
-      this.element.style.display = "";
+      this.element.style.display = "block";
       catcher.watchPromise(callBackground("sendEvent", "internal", "unhide-preview-frame"));
       this.element.focus();
     },