Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Be more careful about capturing text #2174

Closed
ianb opened this issue Feb 16, 2017 · 0 comments
Closed

Be more careful about capturing text #2174

ianb opened this issue Feb 16, 2017 · 0 comments
Assignees
@ianb
Milestone
Sprint 54.2

Comments

@ianb
Copy link
Contributor

ianb commented Feb 16, 2017

If you capture an area that overlaps some big paragraph or text piece, you can potentially get much more text than was in the original image. We should be more cautious.

This is part of what was referred to in #2164
@ianb ianb added this to the Page Shot in 54 milestone Feb 16, 2017
@ianb ianb self-assigned this Mar 3, 2017
@ianb ianb modified the milestones: Page Shot in 54, Sprint 54.2 Mar 9, 2017
jaredhirsch added a commit that referenced this issue Mar 11, 2017
@jaredhirsch
Merge pull request #2356 from mozilla-services/fix-2174
d8c4c4e 
Fix #2174, include left/right and not just top/bottom in the rule for…
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Sprint 54.2
Development

No branches or pull requests
1 participant
@ianb