Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

An infinite spinner is displayed when opening a non-owner shot taken from the latest Nightly Try build if uBlock Origin is installed #2651

Closed
SoftVision-CiprianMuresan opened this issue Apr 12, 2017 · 2 comments · Fixed by #2802
Assignees

Comments

@SoftVision-CiprianMuresan

[Notes]:

  • The issue is not reproducible if the first ever shot is shared (Browser Console errors). However it it reproducible with all subsequent shots.
  • The issue is also reproducible on Chrome with uBlock Origin installed.
  • If I disable uBlock Origin and refresh the page, the image is loaded correctly.
  • The issue is not reproducible if the page is shared from a custom build using the Page Shot dev server.
  • The issue is not reproducible on Chrome or Firefox with AdBlock Plus installed.

[Affected versions]:

  • Firefox 52 and up.

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have uBlock Origin installed on a clean profile.

[Steps to reproduce]:

  1. Open the browser and profile from prerequisites.
  2. Open a non-owner shot taken with the Nightly try build. (eg. https://screenshots.firefox.com/8JSV1y1KERYowIT3/www.imdb.com)
  3. Observe the browser behavior.

[Expected result]:

  • The page is loaded and the image is displayed.

[Actual result]:

  • The page is loaded, but the spinner loops infinitely and the image is not displayed.

[Additional notes]:

  • Here is a screen shot of the issue:
    image
  • Here are the errors shown in the browser console:
    image
@ghost ghost added this to the Screenshots in 54 milestone Apr 12, 2017
@ianb ianb self-assigned this May 3, 2017
ianb added a commit that referenced this issue May 3, 2017
This duplicates some of the React logic that shows the clip image when it loads, but will run even if the bundle doesn't load or there's other Javascript errors.
Incidentally fixes #2651
@ianb
Copy link
Contributor

ianb commented May 3, 2017

This was probably fixed in #2798, but #2792 double-fixes it – the first makes it so uBlock doesn't keep JavaScript from loading, and the second makes it so if the JavaScript bundle fails the image will still be displayed.

ianb added a commit that referenced this issue May 4, 2017
This duplicates some of the React logic that shows the clip image when it loads, but will run even if the bundle doesn't load or there's other Javascript errors.
Incidentally fixes #2651
@SoftVision-CiprianMuresan
Copy link
Author

The issue is no longer reproducible with shots taken with Screenshots from the latest Nightly build.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants