Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Errors are not being reported to Sentry #2920

Closed
ianb opened this issue May 30, 2017 · 8 comments
Closed

Errors are not being reported to Sentry #2920

ianb opened this issue May 30, 2017 · 8 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented May 30, 2017

We have a buildSettings pointing to our prod Sentry, but I don't see any errors there. This is implausibly quiet.

@jaredhirsch
Copy link
Member

can you manually trigger an error, say, by turning off your network connection, then look for a sentry ping attempt in the devtools network tab?

@ghost ghost modified the milestone: Screenshots in 55 May 30, 2017
@ghost ghost added the firefox-55 label May 30, 2017
@jaredhirsch jaredhirsch self-assigned this May 30, 2017
@jaredhirsch
Copy link
Member

I'll take a look at this

@ianb
Copy link
Contributor Author

ianb commented May 30, 2017

FYI, I double-checked the buildSettings.js setting, and it is correct

@jaredhirsch
Copy link
Member

I exported current master into current mozilla-central, built firefox, and Sentry pings are being sent to the correct URL (https://sentry.prod.mozaws.net/api/139/store/? followed by an enormous query string).

The easiest way to test is to switch off wifi, take a screenshot, and try to save it to the server.

This doesn't explain why we aren't seeing anything in the Sentry dashboard, but I did observe that old profiles have an IndexedDB error on today's Nightly, which causes Screenshots to never load, instead crashing on startup.

I'll try next using the ./bin/run-addon approach.

@jaredhirsch
Copy link
Member

jaredhirsch commented May 30, 2017

I can also confirm that Sentry endpoints are pinged if the SCREENSHOTS_SENTRY env var is set when you invoke ./bin/run-addon. Using this incantation:

SCREENSHOTS_SENTRY="https://97d8afa496f94764ae255e739b147f4b@sentry.prod.mozaws.net/139" ./bin/run-addon --bootstrap

I was able to turn off wifi, try to save a shot, then observe a POST attempt to the Sentry endpoint.

edit: fix typo

@jaredhirsch
Copy link
Member

I'm waiting to get Sentry access. I"ll continue debugging once I can view the dashboard.

@jaredhirsch
Copy link
Member

Seems like the issue may be that the addon pings are coming from a randomish moz-extension URL, and may be getting dropped by sentry.

Removing the scary firefox-55 blocker label 🎉

@ianb ianb assigned ianb and unassigned jaredhirsch May 31, 2017
@ianb
Copy link
Contributor Author

ianb commented May 31, 2017

Sadly it looks like request from the background page have no referrer or origin, so there's nothing to whitelist in Sentry. I'm looking into whether we should just ship with the Sentry Private DSN.

More discussion in Bug 1369162

ianb added a commit that referenced this issue Jun 1, 2017
This changes the DSNs to the private DSNs in new Sentry projects
Discussion of using a private DSN in https://bugzilla.mozilla.org/show_bug.cgi?id=1369162
WebExtension background pages do not have a referrer or origin on their requests, therefore we need authenticated endpoints
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants