Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Drop xlink:href (and therefore xmlns:xlink) from all the SVG files #3063

Closed
gijsk opened this issue Jun 26, 2017 · 1 comment
Closed

Drop xlink:href (and therefore xmlns:xlink) from all the SVG files #3063

gijsk opened this issue Jun 26, 2017 · 1 comment
Milestone
Stretch

Comments

@gijsk
Copy link
Collaborator

gijsk commented Jun 26, 2017 •
edited
Loading

https://bugzilla.mozilla.org/show_bug.cgi?id=1359030 turned up:

addon/webextension/icons/back-highlight.svg
addon/webextension/icons/back.svg
addon/webextension/icons/cancel.svg
addon/webextension/icons/done.svg
addon/webextension/icons/download.svg
addon/webextension/icons/icon-welcome-face-without-eyes.svg
addon/webextension/icons/menu-fullpage.svg
addon/webextension/icons/menu-visible.svg

I think the xlink namespace declaration can be dropped from these, and we can use plain href attributes instead of xlink:href for referencing.
@ianb
Copy link
Contributor

ianb commented Jun 30, 2017

I considered doing this with svgo, but on further reflection I think we should just fix this with a text-replace.

@ghost ghost added this to the Stretch milestone Jul 3, 2017
staabm added a commit to staabm/screenshots that referenced this issue Dec 4, 2017
@staabm
Drop xlink:href. use href instead. Fixes mozilla-services#3063.
a22fc09
@staabm staabm mentioned this issue Dec 4, 2017
Merged
@ianb ianb closed this as completed in #3877 Dec 4, 2017
This was referenced Dec 8, 2017
Closed
Closed
This was referenced Apr 19, 2018
Closed
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
2 participants
@ianb @gijsk