Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Create thumbnail of shot #3282

Closed
4 tasks
ianb opened this issue Aug 4, 2017 · 3 comments
Closed
4 tasks

Create thumbnail of shot #3282

ianb opened this issue Aug 4, 2017 · 3 comments
Assignees
Labels
firefox Something that has to ship in the add-on in Firefox P3 perf Performance-related

Comments

@ianb
Copy link
Contributor

ianb commented Aug 4, 2017

We store just the full-resolution shot, which means that My Shots shows really large images as thumbnails. We should generate a thumbnail on shot generation.

This requires:

  • Generating a thumbnail version of the shot
  • Adding a thumbnail parameter to the shot JSON
  • Making sure that thumbnail is moved to S3
  • Making sure the thumbnail is managed like other S3 images (in the images table, etc)

Probably some work on clipRewrites is in order, as it's not very good at finding images in multiple locations in the shot object.

@ianb ianb added the perf Performance-related label Aug 4, 2017
@ghost ghost added this to the General Release 57 milestone Aug 7, 2017
@jaredhirsch
Copy link
Member

What if we do this on the server instead? We could still get this done for 55. Might be a good excuse to bring in a work queue, too.

@ianb
Copy link
Contributor Author

ianb commented Aug 16, 2017

Oh I hate work queues, so I am not looking for any excuses there. But yeah...

As long as the server updates the shot, and selects shots that are missing thumbnails, then the add-on could eventually add the thumbnail and the worker will just have less to do.

@johngruen johngruen added the P3 label Aug 17, 2017
@ghost ghost added the firefox Something that has to ship in the add-on in Firefox label Sep 21, 2017
@ghost ghost modified the milestones: General Release 57, Launch 58 Sep 22, 2017
@chenba
Copy link
Collaborator

chenba commented Oct 17, 2017

This sounds like a dup of #1896.

@chenba chenba self-assigned this Oct 25, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
@johngruen johngruen modified the milestones: Bucket ☕️, Sprint 0 (58-x) Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Oct 31, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 1, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 1, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 1, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 1, 2017
@ghost ghost modified the milestones: Sprint 0 (58-x) 🐘, Sprint 1 (59-0) 🍷 Nov 15, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 23, 2017
chenba added a commit to chenba/screenshots that referenced this issue Nov 27, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
firefox Something that has to ship in the add-on in Firefox P3 perf Performance-related
Projects
None yet
Development

No branches or pull requests

4 participants