Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Tests broken due to Photon-related regression in Nightly #3306

Closed
ianb opened this issue Aug 9, 2017 · 1 comment
Closed

Tests broken due to Photon-related regression in Nightly #3306

ianb opened this issue Aug 9, 2017 · 1 comment
Assignees
@ianb
Milestone
General Release 55

Comments

@ianb
Copy link
Contributor

ianb commented Aug 9, 2017

The tests are broken today, also today when you start the add-on you get the toolbar button and no longer get the pageAction.

Something changed with Nightly and should be fixed, so we get the pageAction. But also our tests should look for the button in either location and work either way.
@johngruen johngruen added this to the General Release 55 milestone Aug 10, 2017
@johngruen
Copy link
Contributor

Discussed in stand up

@ianb ianb self-assigned this Aug 10, 2017
ianb added a commit that referenced this issue Aug 10, 2017
@ianb
Fix #3306, make tests resilient to a browserAction or pageAction
5b648db 
Also the label changed for unknown (but presumably unimportant) reasons
ianb added a commit that referenced this issue Aug 14, 2017
@ianb
Fix #3306, make tests resilient to a browserAction or pageAction (#3317)
cd9bec3 
* Fix #3306, make tests resilient to a browserAction or pageAction
Also the label changed for unknown (but presumably unimportant) reasons

* Disable failure checking for zap test
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
General Release 55
Development

No branches or pull requests
2 participants
@ianb @johngruen