Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Screenshots doesn't work on dxr.mozilla.org #3314

Closed
jaredhirsch opened this issue Aug 10, 2017 · 2 comments
Closed

Screenshots doesn't work on dxr.mozilla.org #3314

jaredhirsch opened this issue Aug 10, 2017 · 2 comments
Assignees
@jaredhirsch
Labels
firefox Something that has to ship in the add-on in Firefox
Milestone
Bucket ☕️

Comments

@jaredhirsch
Copy link
Member

Edge case, I know, but one that will annoy me in perpetuity.

Opening the Screenshots overlay in dxr causes the tab to slow down the entire browser. Hitting the toolbar button again (to dismiss the overlay) does fix the issue.
@ghost ghost added this to the General Release 55 milestone Aug 15, 2017
@jaredhirsch
Copy link
Member Author

We should make sure that searchfox.org (some slight variation on dxr) is performant as well

@ghost ghost modified the milestones: General Release 57, Launch 58 Sep 21, 2017
@ianb ianb added the firefox Something that has to ship in the add-on in Firefox label Oct 10, 2017
@jaredhirsch jaredhirsch mentioned this issue Oct 13, 2017
Closed
@jaredhirsch jaredhirsch self-assigned this Oct 13, 2017
@jaredhirsch
Copy link
Member Author

jaredhirsch commented Oct 13, 2017 •
edited
Loading

dxr has some truly bizarre CSS layout properties. searchfox.org is fine.

dxr renders code using floats inside a non-clearfixed parent. Because the parent has zero calculated height, the selector code spins forever on the while loop.

Adding an empty element check should fix it (#3637).

@ianb ianb closed this as completed in 7c0be97 Oct 16, 2017
ianb added a commit that referenced this issue Oct 16, 2017
@ianb
Merge pull request #3637 from mozilla-services/3314-dxr-fix
2abb4de 
Fix #3314, Avoid infinite selection loop by checking minimum size
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@jaredhirsch jaredhirsch

Labels
firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Milestone
Bucket ☕️
Development

No branches or pull requests
3 participants
@ianb @jaredhirsch @johngruen