Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Create "download only" mode #3574

Closed
ianb opened this issue Oct 2, 2017 · 6 comments
Closed

Create "download only" mode #3574

ianb opened this issue Oct 2, 2017 · 6 comments
Assignees
Labels
firefox Something that has to ship in the add-on in Firefox

Comments

@ianb
Copy link
Contributor

ianb commented Oct 2, 2017

There are a couple situations where we want to let the user use Screenshots and download their shot, but not allow them to upload the shot.

The three cases we are specifically thinking about:

  1. From a Private Browsing window (note we also need Look at new private browsing download support #3274)
  2. When third-party cookies are disabled (see Unable to do anything if the "Never accept third-party cookies" option is set #3572)
  3. When "never remember history" is enabled (see Screenshots is disabled when "Never remember history" is enabled #3196)

To do this bug, potentially only one of these cases might be handled, and we can do a follow-on for the other cases.

The second two are based on Firefox preferences, and we would have to read these preferences in bootstrap.js. This would be sent to the WebExtension in the same manner (or at the same time) as the Telemetry/FHR preference.

@ghost ghost added this to the Launch 58 milestone Oct 3, 2017
@ghost ghost added the needs:product label Oct 3, 2017
@johngruen
Copy link
Contributor

@clouserw why does this need product? We've already discussed this in our standup.

@ghost ghost added needs:UX and removed needs:product labels Oct 4, 2017
@ghost
Copy link

ghost commented Oct 4, 2017

@johngruen only if there is anything around when to show the label. Eg. number 2 up there -- do we want to warn about 3rd party cookies?

Sounds like needs:ux is most appropriate now.

@youwenliang
Copy link
Contributor

Two quick proposals here:
https://mozilla.invisionapp.com/share/WJDTYPTGE

Option A shows a simple message about "Download-only mode" and users can click on the info button to open the tooltip and learn more about what download-only mode is.

Option B shows the whole message in a block placing at the bottom left corner.

This is a temporary copy and it should be modified by copywriters to help users better understand the situation.

@johngruen
Copy link
Contributor

@youwenliang lets go with option A with the caveat that i think that tooltip should just show up on hover, so we can ditch the [x] control

@johngruen johngruen removed the needs:UX label Oct 6, 2017
@johngruen
Copy link
Contributor

johngruen commented Oct 6, 2017

@youwenliang can you provide a measurement spec for option A and then unassign yourself?

@youwenliang
Copy link
Contributor

@youwenliang youwenliang removed their assignment Oct 9, 2017
@ianb ianb added the firefox Something that has to ship in the add-on in Firefox label Oct 11, 2017
@jaredhirsch jaredhirsch self-assigned this Oct 16, 2017
jaredhirsch added a commit that referenced this issue Oct 27, 2017
* Fix #2818, use the private browsing download manager in private browsing mode

Thanks to https://bugzil.la/1362448, webextensions will use the correct
download manager, depending on the `incognito` state of the window.

* Fix #3274, Enable Screenshots in private browsing mode

Leave the l10n string in place, in case this decision is reversed

* Partial fix for #3574, create download only mode for private browsing
@johngruen johngruen modified the milestones: Bucket ☕️, Sprint 0 (58-x) Oct 31, 2017
@ianb ianb closed this as completed in d0d4db3 Oct 31, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

4 participants