Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Check ?rev when serving static files #3962

Closed
ianb opened this issue Jan 10, 2018 · 0 comments
Closed

Check ?rev when serving static files #3962

ianb opened this issue Jan 10, 2018 · 0 comments
Assignees
Labels
ops Something related to our server hosting and deployments P2

Comments

@ianb
Copy link
Contributor

ianb commented Jan 10, 2018

We encountered an issue where an old JavaScript file got cached under a new revision, due to race conditions in the deployment (e.g., someone gets a new app page, but when getting the JavaScript they get routed to an old app server).

I think a simple and fairly safe fix would be to check the ?rev, and if it doesn't match what we expect, then don't let the response be cached. Then everything will mostly work during the deployment (old files will probably work), but old files won't get cached.

@ianb ianb added the ops Something related to our server hosting and deployments label Jan 10, 2018
@ghost ghost added this to the Sprint 6 (60-1) 👨🏼‍🚀 milestone Jan 17, 2018
@ianb ianb added the P2 label Jan 17, 2018
@chenba chenba self-assigned this Mar 1, 2018
chenba added a commit to chenba/screenshots that referenced this issue Mar 1, 2018
@ianb ianb closed this as completed in #4169 Mar 2, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
ops Something related to our server hosting and deployments P2
Projects
None yet
Development

No branches or pull requests

2 participants