Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Crop -> revert -> image shrinks #4509

Closed
jaredhirsch opened this issue May 29, 2018 · 0 comments
Closed

Crop -> revert -> image shrinks #4509

jaredhirsch opened this issue May 29, 2018 · 0 comments
Assignees
@chenba
Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team.
Milestone
Sprint 15 (62-3) ⚽

Comments

@jaredhirsch
Copy link
Member

Note that this is after landing the undo/redo changes, on a 15" MBP, with page zoom at 100%.

  1. Take a shot
  2. Crop
  3. Revert crop
  4. Image is smaller - looks like DPI scaling is being applied twice.

In images:

1. take a shot

image

2. crop

image

3. revert crop

image
Closed
@ghost ghost added this to the Sprint 14 (62-2) ¯\_(ツ)_/¯ milestone May 31, 2018
@ghost ghost assigned chenba May 31, 2018
chenba added a commit to chenba/screenshots that referenced this issue Jun 1, 2018
@chenba
Calculate pixel ratio from the image's natural size. (mozilla-service…
24e723b 
…s#4453, mozilla-services#4509)

- Ensure drawing canvas always match base canvas' dimensions.
- Scale a component's drawing context only when the canvas has been replaced.
@chenba chenba mentioned this issue Jun 2, 2018
Merged
chenba added a commit to chenba/screenshots that referenced this issue Jun 8, 2018
@chenba
Calculate pixel ratio from the image's natural size. (mozilla-service…
c815551 
…s#4453, mozilla-services#4509)

- Ensure drawing canvas always match base canvas' dimensions.
- Scale a component's drawing context only when the canvas has been replaced.
jaredhirsch pushed a commit that referenced this issue Jun 21, 2018
@chenba @jaredhirsch
Calculate pixel ratio from the image's natural size. (#4453, #4509) (#…
fb91a55 
…4516)

- Ensure drawing canvas always match base canvas' dimensions.
- Scale a component's drawing context only when the canvas has been replaced.
@chenba chenba closed this as completed Jun 22, 2018
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Other issue Valid issues logged by other people than the Softvision QA team. label Aug 9, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@chenba chenba

Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team.
Projects
None yet
Milestone
Sprint 15 (62-3) ⚽
Development

No branches or pull requests
3 participants
@jaredhirsch @chenba @SoftVision-CosminMuntean