Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Annotations] Undo/Redo Causes Blurriness on Some Shots #4678

Closed
chenba opened this issue Jul 20, 2018 · 2 comments
Closed

[Annotations] Undo/Redo Causes Blurriness on Some Shots #4678

chenba opened this issue Jul 20, 2018 · 2 comments
Assignees
@chenba
Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
Sprint 18 (63-2)

Comments

@chenba
Copy link
Collaborator

chenba commented Jul 20, 2018

STR

  1. Go to mozilla.org
  2. Take a selection shot of the image used for "IRL season 3: The grand bargain" (see below)
  3. Go shot page
  4. Open editor and add a stroke from the highlighter or pen tool
  5. Click undo

This is the image mentioned in step 2:
image

Expected

Successfully undo without any errors or negative effects

Actual

The rectangular area containing the stroke from step 4 is blurry. Additional undo/redos will make the are even more blurry.
@chenba chenba mentioned this issue Jul 20, 2018
Merged
@ianb ianb added this to the Sprint 18 (63-2) milestone Jul 23, 2018
@chenba chenba self-assigned this Jul 24, 2018
@chenba chenba changed the title Undo/Redo Causes Blurriness on Some Shots [Annotations] Undo/Redo Causes Blurriness on Some Shots Jul 26, 2018
chenba added a commit to chenba/screenshots that referenced this issue Jul 26, 2018
@chenba
Stop using decimal dimensions. (mozilla-services#4678)
67224c1
@chenba chenba mentioned this issue Jul 26, 2018
Merged
@chenba
Copy link
Collaborator Author

chenba commented Jul 26, 2018

QA: the easiest way to test this that I know of is to do selection shots on mozilla.org. Whatever theme it is using produces a lot of elements with decimal width and height.

jaredhirsch pushed a commit that referenced this issue Jul 26, 2018
@chenba @jaredhirsch
Stop using decimal dimensions. (#4678) (#4711)
c2902ee
@SoftVision-CosminMuntean
Copy link

I have verified this issue using latest Screenshots 33.2.0 dev version and it's no longer reproducible. Tested on Windows 7 x64, Mac 10.13 and Ubuntu 16.04.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jul 30, 2018
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Other issue Valid issues logged by other people than the Softvision QA team. label Aug 9, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@chenba chenba

Labels
[QA]:Other issue Valid issues logged by other people than the Softvision QA team. [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
Sprint 18 (63-2)
Development

No branches or pull requests
3 participants
@ianb @chenba @SoftVision-CosminMuntean