Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Track channel and user agent in logins #4748

Closed
ianb opened this issue Aug 6, 2018 · 6 comments
Closed

Track channel and user agent in logins #4748

ianb opened this issue Aug 6, 2018 · 6 comments
Assignees

Comments

@ianb
Copy link
Contributor

ianb commented Aug 6, 2018

We want to distinguish pre-release users (i.e., Nightly and Beta users) from release Firefox users. Right now we're not saving enough in the device table to know the difference.

If we can get the channel information and add it to the login/register call that should be sufficient. Getting the User-Agent wouldn't be as helpful, as you have to match up dates to determine the channel based on the User-Agent. But we could consider User-Agent, as it could be done server-only.

We might want to consider copying the channel information to the shot (data) table on shot creation, so we track which channel the user was using at the moment they uploaded.

@chenba
Copy link
Collaborator

chenba commented Aug 17, 2018

@chenba
Copy link
Collaborator

chenba commented Aug 22, 2018

If we can access prefs with an experiment, which is currently discussed in #4800, then we can grab the channel from the prefs as well.

@ianb
Copy link
Contributor Author

ianb commented Aug 31, 2018

It might be easiest to just use release JSON files on the server: https://wiki.mozilla.org/Release_Management/Product_details

Specifically this file will identify when we should start treating a version as a production release, and this file gives some additional information. My only concern here is that if the file isn't updated very promptly (or ahead of a release) we might be unaware of a version update.

I think a combination of this file, the actual Firefox version, and the date of creation, will give us enough information. We'll want to leave out the last couple days from the report, just because of the possibility of a slow update on a JSON file. It would be great to get the channel from the add-on as well, but... we can do both, if we want to try to move forward on both fronts.

@clouserw
Copy link
Collaborator

clouserw commented Aug 31, 2018

Getting channel from the add-on could be a stretch/enhancement. Grabbing the product details seems easiest and most likely to get done this quarter. We need to get this channel stuff hooked up to finish the Watchdog integration which we're on the hook for this quarter.

@ianb ianb self-assigned this Sep 4, 2018
ianb added a commit that referenced this issue Sep 4, 2018
Given the date and version number we can later deduce the Firefox channel
@chenba
Copy link
Collaborator

chenba commented Sep 4, 2018

AppConstants.MOZ_UPDATE_CHANNEL is available through an experiment API (https://github.com/mozilla-services/screenshots/blob/master/addon/webextension/experiments/screenshots/api.js#L29). Are not we not using that because we want to do everything server side?

@jaredhirsch
Copy link
Member

That API will be available as of Firefox 64, which hits release in December 2018.

ianb added a commit that referenced this issue Sep 5, 2018
Start #4748, add Firefox major version to the shot table
@ianb ianb closed this as completed in c3c6cb7 Sep 20, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants