Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Update Footer component #4846

Closed
punamdahiya opened this issue Sep 6, 2018 · 2 comments · Fixed by #4866
Closed

[FxA] Update Footer component #4846

punamdahiya opened this issue Sep 6, 2018 · 2 comments · Fixed by #4866
Assignees

Comments

@punamdahiya
Copy link
Contributor

Update Footer component as per new UI specs https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/NEW_FxA_Integration/my-shots

@chenba
Copy link
Collaborator

chenba commented Sep 10, 2018

Note that there's a small bug with the current footer. As a side effect of #4819 and the current auth check, the "Remove All Data" link is displayed to all Firefox users who visited more than one shot (or same shot more than once)--that is, has a user cookie--but have never created a shot.

I propose that we only show "Remove All Data" to the owner of the shot.

@johngruen ^ ?

chenba added a commit to chenba/screenshots that referenced this issue Sep 11, 2018
 - Update layout and styles.
 - Fix the bug where "Remove All Data" is shown to non-owners.
@chenba chenba mentioned this issue Sep 11, 2018
@johngruen
Copy link
Contributor

@chenba agree

chenba added a commit to chenba/screenshots that referenced this issue Sep 13, 2018
 - Update layout and styles.
 - Fix the bug where "Remove All Data" is shown to non-owners.
jaredhirsch pushed a commit that referenced this issue Sep 13, 2018
- Update layout and styles.
 - Fix the bug where "Remove All Data" is shown to non-owners.
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants