Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[FxA] Display synced state in my shots page #4847

Closed
jaredhirsch opened this issue Sep 6, 2018 · 8 comments
Closed

[FxA] Display synced state in my shots page #4847

jaredhirsch opened this issue Sep 6, 2018 · 8 comments
Assignees

Comments

@jaredhirsch
Copy link
Member

This comes from discussion in today's Screenshots daily meeting. Feel free to edit this description or add comments to capture additional details I might have missed.

If a user has uploaded shots from Firefox profiles A and B, and connects both A and B to the same Firefox Account, then visiting the My Shots page from either profile will show all shots from A and B.

We don't currently separate the shots from different profiles in any way in the My Shots page.

It's not clear if this will make sense to users in all cases. Cases like logging into FxA on a shared computer, uploading a shot, then logging out of FxA, show that users might reasonably expect their shots to be connected to the account itself, and not the particular device.

Some questions:

  • What are the most important use cases?
  • What are user expectations in those use cases?
  • How do we need to change the Firefox Accounts implementation (UI and backing service code) to fit the use cases and user expectations?
@punamdahiya
Copy link
Contributor

Decision here should influence content in #4870

@youwenliang
Copy link
Contributor

@johngruen
Here's a sync behavior I sketched a while ago:
account behavior

Let me know if this make sense.

@johngruen
Copy link
Contributor

@youwenliang I think we're going to do the treatment where when a user logs out, their on-device shots remain...we should add a visual indicator to each card for shots that come from other devices indicating their origin. Note, we don't have like device device id or anything so maybe just make it visual with a tooltip that says "This shot came from another Firefox"

@youwenliang
Copy link
Contributor

@johngruen is it possible to have different sections in my shot page instead of using indicators on shot cards?

Something like this:
image

@johngruen
Copy link
Contributor

@youwenliang I don't think we should split them up b/c most people are not going to have that many shots...what if we simply add a little sync icon to the upper left corner of any sync'ed shots and then a tool tip that says "Shot taken on another device"

@youwenliang
Copy link
Contributor

youwenliang commented Sep 19, 2018

@johngruen A few ideas here:
fxa screens my shots - sync

Personally I prefer no.2.
Here's the measurement:
https://mozilla.github.io/testpilot-assets/Firefox_Screenshots/FxA_Sync
The sync icon is here in the icon library:
https://design.firefox.com/icons/viewer/#sync

The sync icon will not be clickable (opacity 40%) but if hovered the tooltip will display.

@johngruen
Copy link
Contributor

Yeah, let's go with 2!

@clouserw clouserw added this to the Sprint 22 (64-3) milestone Sep 19, 2018
@jaredhirsch jaredhirsch changed the title [FxA] Rethinking the account/device connection [FxA] Display synced state in my shots page Sep 21, 2018
@jaredhirsch
Copy link
Member Author

Updating the title, since this is now a bug about showing a synced-image icon on the my shots page

@chenba chenba self-assigned this Sep 21, 2018
chenba added a commit to chenba/screenshots that referenced this issue Sep 24, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants