Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The "Shot expired" and "Leave Screenshots" pages should also have a white background #5035

Closed
SoftVision-CosminMuntean opened this issue Oct 12, 2018 · 2 comments
Assignees
Labels
[QA]:Enhancement Label for QA to mark enhancements logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@SoftVision-CosminMuntean

[Affected versions]:

  • Nightly 64.0a1
  • Screenshots 34.0.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • The "xpinstall.signatures.required" boolean pref is set to "false".
  • The "extensions.legacy.enabled" boolean pref is set tot "true".
  • Have the Screenshots 34.0.0 dev version installed from here, on a new clean profile.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to any website and save a selection.
  3. Click the "Remove All Data" link from the footer of the page.
  4. Observe the background of the "Leave Screenshots" page.
  5. Observe the "Page not found" page.

[Expected result]:

  • The background of the page is white.

[Actual results]:

  • The background of the page is dark gray.

[Notes]:

  • Here is a screenshot of a "Shot expired" page:
    image

  • Here is a screenshot of a "Leave Screenshots" page:
    image

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Enhancement Label for QA to mark enhancements logged label Oct 12, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Oct 23, 2018
@punamdahiya punamdahiya self-assigned this Oct 23, 2018
@ianb ianb modified the milestones: Sprint 24 (65-1), Sprint 25 (65-2) 🎃 Oct 29, 2018
@punamdahiya
Copy link
Contributor

Fixed with #5065

@SoftVision-CosminMuntean
Copy link
Author

I have verified this issue and the "Shot expired" and "Leave Screenshots" pages have a white background on latest Screenshtos dev version.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 1, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
[QA]:Enhancement Label for QA to mark enhancements logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Development

No branches or pull requests

3 participants