Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

"#" text in upsell banner should be a link #5054

Closed
jaredhirsch opened this issue Oct 19, 2018 · 3 comments
Closed

"#" text in upsell banner should be a link #5054

jaredhirsch opened this issue Oct 19, 2018 · 3 comments

Comments

@jaredhirsch
Copy link
Member

Seems like a missed opportunity to not linkify the "# or #" text here:

screen shot 2018-10-19 at 11 53 13 am
@yehudab
Copy link
Contributor

yehudab commented Oct 20, 2018

I can take this.
I assume the link should go to: https://www.mozilla.org/en-US/firefox/accounts/, with en-US replaced with the relevant locale.

@yehudab
Copy link
Contributor

yehudab commented Oct 20, 2018 •
edited
Loading

Thinking about it again, I guess a better URL would be: /api/fxa-oauth/#/<current-path>.

yehudab added a commit to yehudab/screenshots that referenced this issue Oct 20, 2018
@yehudab
Make the "# or #" clickable in banner
72618bd 
Fixes: mozilla-services#5054
@yehudab yehudab mentioned this issue Oct 20, 2018
Merged
@ianb ianb added this to the Sprint 25 (65-2) 🎃 milestone Oct 29, 2018
@punamdahiya
Copy link
Contributor

/api/fxa-oauth/#

That's correct, its invokes route handler here

yehudab added a commit to yehudab/screenshots that referenced this issue Oct 29, 2018
@yehudab
Make the "# or #" clickable in banner
f39042c 
Fixes: mozilla-services#5054

CSS fixes:
* Move common colors into variables
* Remove left padding from sign-in link
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ianb @jaredhirsch @punamdahiya @yehudab