Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The smiley face from the Screenshots overlay has just one eye on the latest dev version #5122

Closed
SoftVision-CosminMuntean opened this issue Nov 1, 2018 · 2 comments
Closed

The smiley face from the Screenshots overlay has just one eye on the latest dev version #5122

SoftVision-CosminMuntean opened this issue Nov 1, 2018 · 2 comments
Labels
good first issue [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues skill:css

Comments

@SoftVision-CosminMuntean
Copy link

[Notes]:
-The issue is not reproducible on Mac Book Pro with retina display.

[Affected versions]:

  • Nightly 65.0a1
  • Screenshots 34.0.0 dev

[Affected Platforms]:

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]:

  • Have the latest Screenshots 34.0.0 dev version installed from here.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to any website and click the "Take a Screenshot" from "Page Actions" menu.
  3. Observe the smiley face from the Screenshots overlay.

[Expected result]:

  • The smiley face is correctly displayed.

[Actual results]:

  • The smiley face has only one eye.

[Additional Notes]:

  • Here is a screen recording of the issue:
    smiley face
@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Blocker issue Label for QA to mark blocker issues logged label Nov 1, 2018
@jaredhirsch jaredhirsch added this to the Sprint 25 (65-2) 🎃 milestone Nov 1, 2018
@yehudab
Copy link
Contributor

yehudab commented Nov 2, 2018 •
edited
Loading

This looks like a side-effect of my PR #5055.
I used margin-inline-end instead of margin-inline-start in this case.
PR coming...

yehudab added a commit to yehudab/screenshots that referenced this issue Nov 2, 2018
@yehudab
Fixes mozilla-services#5122 - Use correct logical margins for the lef…
4a85200 
…t/right eyes
punamdahiya added a commit that referenced this issue Nov 7, 2018
@punamdahiya
Merge pull request #5128 from yehudab/cyclop
cf6f087 
Fixes #5122 - Use correct logical margins for the left/right eyes
@SoftVision-CosminMuntean
Copy link
Author

I have verified this issue using the latest Screenshots (34.0.0) dev version and is no longer reproducible. Tested on Windows 7 x64, Mac 10.13 and Arch Linux 4.12.

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 12, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
good first issue [QA]:Blocker issue Label for QA to mark blocker issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues skill:css
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredhirsch @yehudab @SoftVision-CosminMuntean