Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

The Copy string is not localized in supported languages and on certain cases the string is not displayed at all #5146

Closed
LucianaQueirolo opened this issue Nov 5, 2018 · 2 comments
Closed

The Copy string is not localized in supported languages and on certain cases the string is not displayed at all #5146

LucianaQueirolo opened this issue Nov 5, 2018 · 2 comments
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
Release 36.0.0

Comments

@LucianaQueirolo
Copy link

LucianaQueirolo commented Nov 5, 2018 •
edited
Loading

[Affected versions]:
Nightly 65.0a1
Screenshots 34.0.0 dev

[Affected Platforms]:
Windows 10

[Prerequisites]:

  • Have the latest Screenshots 34.0.0 dev version installed from here.
  • Have several selections saved in the profile.
  • Have the browser set to Spanish (Spain)

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to any website and click the "Take a Screenshot" from "Page Actions" menu.
  3. Save a selection.
  4. On the selection page, click on "All shots" button.
  5. In "All shots" page, hover a shot, then click on "Share" button
  6. See how "Copy" text is displayed on the button.

[Expected result]:

  • The Copy string is localized in supported languages and is displayed inside the button.

[Actual results]:

  • The Copy string is not localized in supported languages and on certain cases the string is not displayed at all.

[Additional Notes]:
screenshots - chrome - copy button text
copy button spanish - english text
@LucianaQueirolo LucianaQueirolo changed the title The Copy string is not localized in supported languages and on certain cases the string is not displayed at all. The Copy string is not localized in supported languages and on certain cases the string is not displayed at all Nov 5, 2018
@punamdahiya
Copy link
Contributor

It seems shotPageCopy string is missing from server.ftl

@SoftVision-CosminMuntean SoftVision-CosminMuntean added the [QA]:Normal issue Label for QA to mark normal issues logged label Nov 6, 2018
@johngruen johngruen added this to the Sprint 26 (65-3) milestone Nov 6, 2018
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Nov 8, 2018
@punamdahiya
Fixes mozilla-services#5146 - Copy string on myshots page shows blank
efe493f
punamdahiya added a commit to punamdahiya/screenshots that referenced this issue Nov 8, 2018
@punamdahiya
Fixes mozilla-services#5146 - Copy string on myshots shows blank
29298c2
@LucianaQueirolo
Copy link
Author

I have verified this issue using the latest Screenshots (34.0.0) dev version and is no longer reproducible. Tested on Windows 10 x64, Mac 10.13.4

@LucianaQueirolo LucianaQueirolo added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 12, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
[QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
Release 36.0.0
Development

No branches or pull requests
4 participants
@punamdahiya @johngruen @SoftVision-CosminMuntean @LucianaQueirolo